Re: [PR] Encryption integration and test [iceberg]

["szlta (via GitHub)" <gi...@apache.org>]

szlta commented on code in PR #13066:
URL: https://github.com/apache/iceberg/pull/13066#discussion_r2102385609


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -124,13 +184,37 @@ protected void doRefresh() {
       throw new RuntimeException("Interrupted during refresh", e);
     }
 
+    if (encryptionKeyIdFromHMS != null) {
+      encryptionKeyId = encryptionKeyIdFromHMS; // todo gg
+      encryptionDekLength =
+          (dekLengthFromHMS != null)
+              ? Integer.parseInt(dekLengthFromHMS)
+              : TableProperties.ENCRYPTION_DEK_LENGTH_DEFAULT; // todo gg
+    }
+
     refreshFromMetadataLocation(metadataLocation, metadataRefreshMaxRetries);
+
+    if (encryptionKeyIdFromHMS != null) {
+      checkEncryptionProperties(encryptionKeyIdFromHMS, dekLengthFromHMS);
+      encryptedKeysFromMetadata = current().encryptionKeys();
+    }
   }
 
   @SuppressWarnings({"checkstyle:CyclomaticComplexity", "MethodLength"})
   @Override
   protected void doCommit(TableMetadata base, TableMetadata metadata) {
     boolean newTable = base == null;
+    encryptionPropsFromMetadata(metadata.properties());
+
+    if (encryption() instanceof StandardEncryptionManager) {
+      TableMetadata.Builder builder = TableMetadata.buildFrom(metadata);
+      for (Map.Entry<String, EncryptedKey> entry :
+          EncryptionUtil.encryptionKeys(encryption()).entrySet()) {

Review Comment:
   `EncryptionUtil.encryptionKeys` seems like a missing part of the PR, could you check please?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org