You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by GitBox <gi...@apache.org> on 2019/12/21 18:33:39 UTC
[GitHub] [jena] afs opened a new pull request #662: JENA-1806: Update
examples
afs opened a new pull request #662: JENA-1806: Update examples
URL: https://github.com/apache/jena/pull/662
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] Claudenw commented on issue #662: JENA-1806: Update examples
Posted by GitBox <gi...@apache.org>.
Claudenw commented on issue #662: JENA-1806: Update examples
URL: https://github.com/apache/jena/pull/662#issuecomment-568257552
These changes are in place. I assume this is to correct issues before moving them to the jena-examples project. Is that corect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] kinow commented on a change in pull request #662: JENA-1806:
Update examples
Posted by GitBox <gi...@apache.org>.
kinow commented on a change in pull request #662: JENA-1806: Update examples
URL: https://github.com/apache/jena/pull/662#discussion_r360667830
##########
File path: jena-tdb/src-examples/tdb/examples/ExTDB_Txn2.java
##########
@@ -18,66 +18,56 @@
package tdb.examples;
-import org.apache.jena.atlas.lib.StrUtils ;
+import org.apache.jena.atlas.lib.StrUtils;
+import org.apache.jena.query.Dataset;
+import org.apache.jena.system.Txn;
+import org.apache.jena.tdb.TDBFactory;
+import org.apache.jena.update.UpdateExecutionFactory;
+import org.apache.jena.update.UpdateFactory;
+import org.apache.jena.update.UpdateProcessor;
+import org.apache.jena.update.UpdateRequest;
-import org.apache.jena.query.Dataset ;
-import org.apache.jena.query.ReadWrite ;
-import org.apache.jena.tdb.TDBFactory ;
-import org.apache.jena.update.GraphStore ;
-import org.apache.jena.update.GraphStoreFactory ;
-import org.apache.jena.update.UpdateExecutionFactory ;
-import org.apache.jena.update.UpdateFactory ;
-import org.apache.jena.update.UpdateProcessor ;
-import org.apache.jena.update.UpdateRequest ;
-
-/** Example of a WRITE transaction. */
-public class ExTDB_Txn2
-{
- public static void main(String... argv)
- {
- String directory = "MyDatabases/DB1" ;
- Dataset dataset = TDBFactory.createDataset(directory) ;
+/**
+ * Example of a WRITE transaction.
+ * See {@link Txn#executeRead}.
+ */
+public class ExTDB_Txn2 {
+ public static void main(String...argv) {
+ String directory = "MyDatabases/DB1";
+ Dataset dataset = TDBFactory.createDataset(directory);
- // Start WRITE transaction.
- // It's possible to read from the datet inside the write transaction.
+ // Start WRITE transaction.
+ // It's possible to read from the datet inside the write transaction.
Review comment:
s/datet/dataset ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs commented on issue #662: JENA-1806: Update examples
Posted by GitBox <gi...@apache.org>.
afs commented on issue #662: JENA-1806: Update examples
URL: https://github.com/apache/jena/pull/662#issuecomment-568273228
The changes are orthogonal to whether to move or not.
There were comments on email and on JENA-1806 so let's discuss the details there.
The idea of moving the examples is good - needs some details and refinement next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs commented on a change in pull request #662: JENA-1806:
Update examples
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #662: JENA-1806: Update examples
URL: https://github.com/apache/jena/pull/662#discussion_r360893994
##########
File path: jena-tdb/src-examples/tdb/examples/ExTDB_Txn2.java
##########
@@ -18,66 +18,56 @@
package tdb.examples;
-import org.apache.jena.atlas.lib.StrUtils ;
+import org.apache.jena.atlas.lib.StrUtils;
+import org.apache.jena.query.Dataset;
+import org.apache.jena.system.Txn;
+import org.apache.jena.tdb.TDBFactory;
+import org.apache.jena.update.UpdateExecutionFactory;
+import org.apache.jena.update.UpdateFactory;
+import org.apache.jena.update.UpdateProcessor;
+import org.apache.jena.update.UpdateRequest;
-import org.apache.jena.query.Dataset ;
-import org.apache.jena.query.ReadWrite ;
-import org.apache.jena.tdb.TDBFactory ;
-import org.apache.jena.update.GraphStore ;
-import org.apache.jena.update.GraphStoreFactory ;
-import org.apache.jena.update.UpdateExecutionFactory ;
-import org.apache.jena.update.UpdateFactory ;
-import org.apache.jena.update.UpdateProcessor ;
-import org.apache.jena.update.UpdateRequest ;
-
-/** Example of a WRITE transaction. */
-public class ExTDB_Txn2
-{
- public static void main(String... argv)
- {
- String directory = "MyDatabases/DB1" ;
- Dataset dataset = TDBFactory.createDataset(directory) ;
+/**
+ * Example of a WRITE transaction.
+ * See {@link Txn#executeRead}.
+ */
+public class ExTDB_Txn2 {
+ public static void main(String...argv) {
+ String directory = "MyDatabases/DB1";
+ Dataset dataset = TDBFactory.createDataset(directory);
- // Start WRITE transaction.
- // It's possible to read from the datet inside the write transaction.
+ // Start WRITE transaction.
+ // It's possible to read from the datet inside the write transaction.
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs merged pull request #662: JENA-1806: Update examples
Posted by GitBox <gi...@apache.org>.
afs merged pull request #662: JENA-1806: Update examples
URL: https://github.com/apache/jena/pull/662
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services