You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Amogh Margoor (Code Review)" <ge...@cloudera.org> on 2021/06/09 11:48:10 UTC
[Impala-ASF-CR] IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
Amogh Margoor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17567
Change subject: IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
......................................................................
IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
Built-in function has been added to compute MD5 128-bit checksum for
a non-null string. If input string is null, then output of the
function is null too. In FIPS mode, MD5 is disabled and function
will throw error on invocation.
Testing:
1. Added expression unit tests.
2. Added end-to-end tests for MD5.
Change-Id: Id406d30a7cc6573212b302fbfec43eb848352ff2
---
M be/src/exprs/expr-test.cc
M be/src/exprs/utility-functions-ir.cc
M be/src/exprs/utility-functions.h
M common/function-registry/impala_functions.py
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
5 files changed, 44 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/17567/1
--
To view, visit http://gerrit.cloudera.org:8080/17567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id406d30a7cc6573212b302fbfec43eb848352ff2
Gerrit-Change-Number: 17567
Gerrit-PatchSet: 1
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
[Impala-ASF-CR] IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17567 )
Change subject: IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
......................................................................
Patch Set 1: Code-Review+2
Nice work!
--
To view, visit http://gerrit.cloudera.org:8080/17567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id406d30a7cc6573212b302fbfec43eb848352ff2
Gerrit-Change-Number: 17567
Gerrit-PatchSet: 1
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 16:37:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17567 )
Change subject: IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8867/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id406d30a7cc6573212b302fbfec43eb848352ff2
Gerrit-Change-Number: 17567
Gerrit-PatchSet: 1
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jun 2021 12:09:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17567 )
Change subject: IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id406d30a7cc6573212b302fbfec43eb848352ff2
Gerrit-Change-Number: 17567
Gerrit-PatchSet: 2
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 22:24:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17567 )
Change subject: IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id406d30a7cc6573212b302fbfec43eb848352ff2
Gerrit-Change-Number: 17567
Gerrit-PatchSet: 2
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 16:38:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17567 )
Change subject: IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
......................................................................
IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
Built-in function has been added to compute MD5 128-bit checksum for
a non-null string. If input string is null, then output of the
function is null too. In FIPS mode, MD5 is disabled and function
will throw error on invocation.
Testing:
1. Added expression unit tests.
2. Added end-to-end tests for MD5.
Change-Id: Id406d30a7cc6573212b302fbfec43eb848352ff2
Reviewed-on: http://gerrit.cloudera.org:8080/17567
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/expr-test.cc
M be/src/exprs/utility-functions-ir.cc
M be/src/exprs/utility-functions.h
M common/function-registry/impala_functions.py
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
5 files changed, 44 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id406d30a7cc6573212b302fbfec43eb848352ff2
Gerrit-Change-Number: 17567
Gerrit-PatchSet: 3
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17567 )
Change subject: IMPALA-10730: Add MD5 fuction to compute 128-bit checksum for a string.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7217/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id406d30a7cc6573212b302fbfec43eb848352ff2
Gerrit-Change-Number: 17567
Gerrit-PatchSet: 2
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 16:38:04 +0000
Gerrit-HasComments: No