You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/12/16 02:35:17 UTC

[GitHub] [servicecomb-service-center] hityc2019 commented on pull request #784: extract role_resource duplicate code in method to a public method

hityc2019 commented on pull request #784:
URL: https://github.com/apache/servicecomb-service-center/pull/784#issuecomment-745724522


   > 在 golangci-lint的配置中增加dupl，看看门禁是否能过
   > 
   > --enable golint,gocyclo,goimports,dupl
   
   在本地测试是通过了的，不过其它文件如`server\rest\controller\v4\dependency_controller.go:69-90`, `server\broker\service.go:108-258`等文件的重复代码较高
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org