[GitHub] [beam] damccorm commented on a diff in pull request #23182: [WIP]Pass namespace through RunInference transform

[GitBox <gi...@apache.org>]

damccorm commented on code in PR #23182:
URL: https://github.com/apache/beam/pull/23182#discussion_r970838379


##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -321,9 +324,10 @@ def expand(
         # TODO(https://github.com/apache/beam/issues/21440): Hook into the
         # batching DoFn APIs.
         | beam.BatchElements(**self._model_handler.batch_elements_kwargs())
-        | (
+        | 'RunInference_DoFn' >> (

Review Comment:
   Lets follow the convention described here: https://docs.google.com/document/d/1qEfYoTzTnBUeQJrD_mK2bMFmcpBRIIWiMZItcZys19I/edit
   
   ```suggestion
           | 'BeamML_RunInference' >> (
   ```
   
   Could we actually do the same with our default metrics namespaces as part of this change too? e.g. https://github.com/apache/beam/blob/70f1c71525903b9d0474efab476c0e199267e757/sdks/python/apache_beam/ml/inference/pytorch_inference.py#L199 would go from `RunInferencePytorch` -> `BeamML_Pytorch_RunInference` (and the same would happen for the other frameworks)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org