[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9167: [fix](storage)bloom filter support ColumnDict

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #9167:
URL: https://github.com/apache/incubator-doris/pull/9167#discussion_r857062810


##########
be/src/exprs/bloomfilter_predicate.h:
##########
@@ -65,6 +65,10 @@ class BlockBloomFilterAdaptor {
         return _bloom_filter->find(Slice(data, len));
     }
 
+    bool test_uint32_t(uint32_t data) const {

Review Comment:
   should refactor code of `test_bytes` and `test_uint32_t` use template to make code clear.
   



##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -297,6 +307,23 @@ class ColumnDictionary final : public COWHelper<IColumn, ColumnDictionary<T>> {
             return -1;
         }
 
+        inline StringValue& get_value(T code) { return _dict_data[code]; }
+        
+        inline void generate_hash_values() {
+            if (_hash_values.size() == 0) {
+                _hash_values.reserve(_dict_data.size());

Review Comment:
   why not `resize` and `_hash_values[i] = HashUtil::murmur_hash3_32(sv.ptr, sv.len, 0);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org