[GitHub] [activemq] thodimi1 commented on a change in pull request #523: AMQ-7467 - A new XStream serializer is created on every message that flows through the broker causing high CPU utilization under load

[GitBox <gi...@apache.org>]

thodimi1 commented on a change in pull request #523:
URL: https://github.com/apache/activemq/pull/523#discussion_r426158501



##########
File path: activemq-stomp/src/main/java/org/apache/activemq/transport/stomp/ProtocolConverter.java
##########
@@ -280,11 +294,7 @@ protected void handleException(Throwable exception, StompFrame command) throws I
         // Let the stomp client know about any protocol errors.
         ByteArrayOutputStream baos = new ByteArrayOutputStream();
         PrintWriter stream = new PrintWriter(new OutputStreamWriter(baos, "UTF-8"));
-        if (exception instanceof SecurityException || exception.getCause() instanceof SecurityException) {
-            stream.write(exception.getLocalizedMessage());
-        } else {
-            exception.printStackTrace(stream);
-        }
+        exception.printStackTrace(stream);

Review comment:
       Corrected




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org