You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by edespino <gi...@git.apache.org> on 2016/09/20 20:18:23 UTC
[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...
GitHub user edespino opened a pull request:
https://github.com/apache/incubator-hawq/pull/921
HAWQ-1064. Additional work related to paramiko removal.
The python module paramiko was replaced with pexpect-4.2 &
ptyprocess-0.5.1. The following additional changes are needed:
* LICENSE file needs to be updated
* The references to paramiko need to be removed from tools/bin/Makefile & tools/bin/lib/.gitignore
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/edespino/incubator-hawq master-HAWQ-1064
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/921.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #921
----
commit d209fd527c54b9ddc3ff9c9c177340d36a3e8db8
Author: Ed Espino <es...@apache.org>
Date: 2016-09-20T20:12:00Z
HAWQ-1064. Additional work related to paramiko removal.
The python module paramiko was replaced with pexpect-4.2 &
ptyprocess-0.5.1. The following additional changes are needed:
* LICENSE file needs to be updated
* The references to paramiko need to be removed from tools/bin/Makefile & tools/bin/lib/.gitignore
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #921: HAWQ-1064. Additional work related to paramiko re...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/921
Thanks for fix it.
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #921: HAWQ-1064. Additional work related to paramiko re...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on the issue:
https://github.com/apache/incubator-hawq/pull/921
Radar, I will remove paramiko from .travis.yml. Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/921#discussion_r79763445
--- Diff: tools/bin/lib/.gitignore ---
@@ -2,7 +2,3 @@ netperf
netserver
stream
Crypto
--- End diff --
+1. Good catch for the whole issue.
By the way, tools/Makefile seems to be buggy. See the following patch.
This misleads me also. @ edespino and @radarwave ,
how about the patch below? If yes, Ed you probably could
add this change in you patch?
diff --git a/tools/Makefile b/tools/Makefile
index 172f6f6..3eb49f6 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -27,6 +27,7 @@ include $(top_builddir)/src/Makefile.global
all:
${MAKE} -C gpnetbench $@
+ ${MAKE} -C bin $@
install :
${MAKE} -C bin $@
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/921#discussion_r79770123
--- Diff: tools/bin/lib/.gitignore ---
@@ -2,7 +2,3 @@ netperf
netserver
stream
Crypto
--- End diff --
Looks good. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/921#discussion_r79745254
--- Diff: tools/bin/lib/.gitignore ---
@@ -2,7 +2,3 @@ netperf
netserver
stream
Crypto
--- End diff --
We seem to be able to remove this file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...
Posted by edespino <gi...@git.apache.org>.
Github user edespino closed the pull request at:
https://github.com/apache/incubator-hawq/pull/921
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/921#discussion_r79769283
--- Diff: tools/bin/lib/.gitignore ---
@@ -2,7 +2,3 @@ netperf
netserver
stream
Crypto
--- End diff --
@paul-guo- I have incorporated your patch into this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #921: HAWQ-1064. Additional work related to paramiko re...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/921
BTW, could you help to delete pramiko in .travis.yml.
This can save a little time to get travis result. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #921: HAWQ-1064. Additional work related to para...
Posted by edespino <gi...@git.apache.org>.
Github user edespino commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/921#discussion_r79760929
--- Diff: tools/bin/lib/.gitignore ---
@@ -2,7 +2,3 @@ netperf
netserver
stream
Crypto
--- End diff --
The tools/bin/Makefile processes the "stream" target and the executable "stream" is copied to tools/bin/lib/stream. Thus the "stream" entry in the .gitignore file is used.
I will remove the other entries and leave the "stream" reference.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---