You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by pt...@apache.org on 2009/02/03 21:39:06 UTC
svn commit: r740430 - in /jakarta/cactus/trunk/samples/servlet/src:
main/java/org/apache/cactus/sample/servlet/util/
test/java/org/apache/cactus/sample/servlet/
test/java/org/apache/cactus/sample/servlet/unit/
Author: ptahchiev
Date: Tue Feb 3 20:39:05 2009
New Revision: 740430
URL: http://svn.apache.org/viewvc?rev=740430&view=rev
Log:
Checkstyle improved.
Modified:
jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/FilterServletOutputStream.java
jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/GenericResponseWrapper.java
jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleBodyTag.java
jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleTag.java
jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestCookie.java
jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHtmlUnitIntegration.java
jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHttpUnitIntegration.java
jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestJspTagLifecycle.java
Modified: jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/FilterServletOutputStream.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/FilterServletOutputStream.java?rev=740430&r1=740429&r2=740430&view=diff
==============================================================================
--- jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/FilterServletOutputStream.java (original)
+++ jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/FilterServletOutputStream.java Tue Feb 3 20:39:05 2009
@@ -42,7 +42,7 @@
public class FilterServletOutputStream extends ServletOutputStream
{
/**
- * The stream where all the data will get written to
+ * The stream where all the data will get written to.
*/
private DataOutputStream stream;
Modified: jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/GenericResponseWrapper.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/GenericResponseWrapper.java?rev=740430&r1=740429&r2=740430&view=diff
==============================================================================
--- jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/GenericResponseWrapper.java (original)
+++ jakarta/cactus/trunk/samples/servlet/src/main/java/org/apache/cactus/sample/servlet/util/GenericResponseWrapper.java Tue Feb 3 20:39:05 2009
@@ -46,7 +46,7 @@
public class GenericResponseWrapper extends HttpServletResponseWrapper
{
/**
- * Holder for the output data
+ * Holder for the output data.
*/
private ByteArrayOutputStream output;
Modified: jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleBodyTag.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleBodyTag.java?rev=740430&r1=740429&r2=740430&view=diff
==============================================================================
--- jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleBodyTag.java (original)
+++ jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleBodyTag.java Tue Feb 3 20:39:05 2009
@@ -34,7 +34,7 @@
public class TestSampleBodyTag extends JspTestCase
{
/**
- * Our tag instance being unit tested
+ * Our tag instance being unit tested.
*/
private SampleBodyTag tag;
Modified: jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleTag.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleTag.java?rev=740430&r1=740429&r2=740430&view=diff
==============================================================================
--- jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleTag.java (original)
+++ jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/TestSampleTag.java Tue Feb 3 20:39:05 2009
@@ -33,7 +33,7 @@
public class TestSampleTag extends JspTestCase
{
/**
- * Our tag instance to unit test
+ * Our tag instance to unit test.
*/
private SampleTag tag;
@@ -147,7 +147,7 @@
/**
* Checks if the tag will signal that page processing should stop if
- * stopPage is set to "true"
+ * stopPage is set to "true".
*
* @exception Exception if the test fails for an unexpected reason
*/
Modified: jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestCookie.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestCookie.java?rev=740430&r1=740429&r2=740430&view=diff
==============================================================================
--- jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestCookie.java (original)
+++ jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestCookie.java Tue Feb 3 20:39:05 2009
@@ -31,7 +31,7 @@
public class TestCookie extends ServletTestCase
{
/**
- * Verify that special characters in cookies are not URL encoded
+ * Verify that special characters in cookies are not URL encoded.
*
* @param theRequest the request object that serves to initialize the
* HTTP connection to the server redirector.
@@ -44,7 +44,7 @@
}
/**
- * Verify that special characters in cookies are not encoded
+ * Verify that special characters in cookies are not encoded.
*/
public void testCookieEncoding()
{
Modified: jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHtmlUnitIntegration.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHtmlUnitIntegration.java?rev=740430&r1=740429&r2=740430&view=diff
==============================================================================
--- jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHtmlUnitIntegration.java (original)
+++ jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHtmlUnitIntegration.java Tue Feb 3 20:39:05 2009
@@ -46,7 +46,7 @@
}
/**
- * Verify that HttpUnit integration works
+ * Verify that HttpUnit integration works.
*
* @param theResponse the response from the server side.
*
@@ -98,10 +98,11 @@
/**
* Verify that we can initialize the <code>SampleServlet</code> and
* assert it in endXXX().
- *
- * @param theResponse the response from the server side.
+ *
+ * @throws Exception in case an error occurs
*/
- public void testSampleServletResponse() throws Exception {
+ public void testSampleServletResponse() throws Exception
+ {
SampleServlet servlet = new SampleServlet();
servlet.doGet(request, response);
}
@@ -111,11 +112,14 @@
*
* @param theResponse the response from the server side.
*
- * @exception IOException on test failure
+ * @throws Exception on test failure
*/
- public void endSampleServletResponse(com.gargoylesoftware.htmlunit.WebResponse
- theResponse) throws Exception {
- assertEquals("<html><head/><body>A GET request</body></html>", theResponse.getContentAsString());
+ public void endSampleServletResponse(
+ com.gargoylesoftware.htmlunit.WebResponse theResponse)
+ throws Exception
+ {
+ assertEquals("<html><head/><body>A GET request</body></html>",
+ theResponse.getContentAsString());
}
}
Modified: jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHttpUnitIntegration.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHttpUnitIntegration.java?rev=740430&r1=740429&r2=740430&view=diff
==============================================================================
--- jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHttpUnitIntegration.java (original)
+++ jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestHttpUnitIntegration.java Tue Feb 3 20:39:05 2009
@@ -45,7 +45,7 @@
}
/**
- * Verify that HttpUnit integration works
+ * Verify that HttpUnit integration works.
*
* @param theResponse the response from the server side.
*
Modified: jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestJspTagLifecycle.java
URL: http://svn.apache.org/viewvc/jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestJspTagLifecycle.java?rev=740430&r1=740429&r2=740430&view=diff
==============================================================================
--- jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestJspTagLifecycle.java (original)
+++ jakarta/cactus/trunk/samples/servlet/src/test/java/org/apache/cactus/sample/servlet/unit/TestJspTagLifecycle.java Tue Feb 3 20:39:05 2009
@@ -44,7 +44,7 @@
* <p>
* The lifecycle helper is tested here by testing the core tags of the
* reference implementation of the JSP standard tag library (JSTL), available
- * at <a href="http://jakarta.apache.org/taglibs/">.
+ * at <a href="http://jakarta.apache.org/taglibs/">http://jakarta.apache.org/taglibs/</a>.
* </p>
*
* @version $Id: TestJspTagLifecycle.java 238816 2004-02-29 16:36:46Z vmassol $
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org