You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Robert McGuinness (JIRA)" <ji...@apache.org> on 2011/07/11 04:04:59 UTC
[jira] [Created] (WICKET-3884) Null model for AttributeAppender
should not render empty attribute
Null model for AttributeAppender should not render empty attribute
------------------------------------------------------------------
Key: WICKET-3884
URL: https://issues.apache.org/jira/browse/WICKET-3884
Project: Wicket
Issue Type: Bug
Components: wicket-core
Affects Versions: 1.5-RC5.1
Reporter: Robert McGuinness
Priority: Trivial
I can't think of a reason this would be valid, but passing in null model renders <span class="">Test</span>. If previous and new attribute are both null, the component should render cleanly like <span>Test</span>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-3884) Null model for AttributeAppender
should not render empty attribute
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3884:
---------------------------------------
Assignee: Martijn Dashorst
> Null model for AttributeAppender should not render empty attribute
> ------------------------------------------------------------------
>
> Key: WICKET-3884
> URL: https://issues.apache.org/jira/browse/WICKET-3884
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC5.1
> Reporter: Robert McGuinness
> Assignee: Martijn Dashorst
> Priority: Trivial
> Labels: attributes
> Attachments: test-WICKET-3884.patch
>
>
> I can't think of a reason this would be valid, but passing in null model renders <span class="">Test</span>. If previous and new attribute are both null, the component should render cleanly like <span>Test</span>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3884) Null model for AttributeAppender
should not render empty attribute
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067789#comment-13067789 ]
Martin Grigorov commented on WICKET-3884:
-----------------------------------------
I think special values VA_ADD and VA_REMOVE should be deprecated.
If AttributeModifier should be able to remove an attribute then explicit #remove(String) method should be added.
> Null model for AttributeAppender should not render empty attribute
> ------------------------------------------------------------------
>
> Key: WICKET-3884
> URL: https://issues.apache.org/jira/browse/WICKET-3884
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC5.1
> Reporter: Robert McGuinness
> Assignee: Martijn Dashorst
> Priority: Trivial
> Labels: attributes
> Attachments: attr-modifier-by-identity.patch, test-WICKET-3884.patch
>
>
> I can't think of a reason this would be valid, but passing in null model renders <span class="">Test</span>. If previous and new attribute are both null, the component should render cleanly like <span>Test</span>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3884) Null model for AttributeAppender
should not render empty attribute
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3884:
------------------------------------
Attachment: attr-modifier-by-identity.patch
While working on this I'd like to ask about the checks for VALUELESS_ constants: isn't it better to use checks for equality by identity instead of .equals() ?
With .equals() it is not possible to use values 'VA_ADD' and 'VA_REMOVE'. Using new String() and == will solve this. The constants are static so this shouldn't be a problem for deserialization. What do you think ?
> Null model for AttributeAppender should not render empty attribute
> ------------------------------------------------------------------
>
> Key: WICKET-3884
> URL: https://issues.apache.org/jira/browse/WICKET-3884
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC5.1
> Reporter: Robert McGuinness
> Assignee: Martijn Dashorst
> Priority: Trivial
> Labels: attributes
> Attachments: attr-modifier-by-identity.patch, test-WICKET-3884.patch
>
>
> I can't think of a reason this would be valid, but passing in null model renders <span class="">Test</span>. If previous and new attribute are both null, the component should render cleanly like <span>Test</span>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3884) Null model for AttributeAppender
should not render empty attribute
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3884.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC6
Assignee: Martin Grigorov (was: Martijn Dashorst)
> Null model for AttributeAppender should not render empty attribute
> ------------------------------------------------------------------
>
> Key: WICKET-3884
> URL: https://issues.apache.org/jira/browse/WICKET-3884
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC5.1
> Reporter: Robert McGuinness
> Assignee: Martin Grigorov
> Priority: Trivial
> Labels: attributes
> Fix For: 1.5-RC6
>
> Attachments: attr-modifier-by-identity.patch, test-WICKET-3884.patch
>
>
> I can't think of a reason this would be valid, but passing in null model renders <span class="">Test</span>. If previous and new attribute are both null, the component should render cleanly like <span>Test</span>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3884) Null model for AttributeAppender
should not render empty attribute
Posted by "Pedro Santos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067819#comment-13067819 ]
Pedro Santos commented on WICKET-3884:
--------------------------------------
+1 to deprecate VA_ADD and VA_REMOVE in benefit of #remove(String), it is better to read.
> Null model for AttributeAppender should not render empty attribute
> ------------------------------------------------------------------
>
> Key: WICKET-3884
> URL: https://issues.apache.org/jira/browse/WICKET-3884
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC5.1
> Reporter: Robert McGuinness
> Assignee: Martijn Dashorst
> Priority: Trivial
> Labels: attributes
> Attachments: attr-modifier-by-identity.patch, test-WICKET-3884.patch
>
>
> I can't think of a reason this would be valid, but passing in null model renders <span class="">Test</span>. If previous and new attribute are both null, the component should render cleanly like <span>Test</span>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3884) Null model for AttributeAppender
should not render empty attribute
Posted by "Robert McGuinness (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert McGuinness updated WICKET-3884:
--------------------------------------
Attachment: test-WICKET-3884.patch
Failing test case added
> Null model for AttributeAppender should not render empty attribute
> ------------------------------------------------------------------
>
> Key: WICKET-3884
> URL: https://issues.apache.org/jira/browse/WICKET-3884
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC5.1
> Reporter: Robert McGuinness
> Priority: Trivial
> Labels: attributes
> Attachments: test-WICKET-3884.patch
>
>
> I can't think of a reason this would be valid, but passing in null model renders <span class="">Test</span>. If previous and new attribute are both null, the component should render cleanly like <span>Test</span>.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira