[jira] [Created] (NUTCH-2850) Method ignores exceptional return value

["Lewis John McGibbney (Jira)" <ji...@apache.org>]

Lewis John McGibbney created NUTCH-2850:
-------------------------------------------

             Summary: Method ignores exceptional return value
                 Key: NUTCH-2850
                 URL: https://issues.apache.org/jira/browse/NUTCH-2850
             Project: Nutch
          Issue Type: Sub-task
          Components: dumpers
    Affects Versions: 1.18
            Reporter: Lewis John McGibbney
            Assignee: Lewis John McGibbney
             Fix For: 1.19


In class org.apache.nutch.tools.FileDumper
In method org.apache.nutch.tools.FileDumper.dump(File, File, String[], boolean, boolean, boolean)
Called method java.io.File.mkdirs()
At FileDumper.java:[line 237]
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.nutch.tools.FileDumper.dump(File, File, String[], boolean, boolean, boolean)

This method returns a value that is not checked. The return value should be checked since it can indicate an unusual or unexpected function execution. For example, the File.delete() method returns false if the file could not be successfully deleted (rather than throwing an Exception). If you don't check the result, you won't notice if the method invocation signals unexpected behavior by returning an atypical return value. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)