You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2013/07/03 16:02:09 UTC

[Bug 55193] New: ErrorLogFormat is ignored by some modules

https://issues.apache.org/bugzilla/show_bug.cgi?id=55193

            Bug ID: 55193
           Summary: ErrorLogFormat is ignored by some modules
           Product: Apache httpd-2
           Version: 2.5-HEAD
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Core
          Assignee: bugs@httpd.apache.org
          Reporter: dave@alfar.co.uk

Created attachment 30532
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30532&action=edit
Fall back to ap_server_conf for ErrorLogFormat

Modules that do not provide s->module_config (such as mod_cgid) completely
bypass any ErrorLogFormat directives and get the default error log format
applied to all error messages generated by them.

Possible solution is to drop back to ap_server_conf->module_config where
available (patch enclosed)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 55193] ErrorLogFormat is ignored by some modules

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55193

Dave <da...@alfar.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |minor

--- Comment #1 from Dave <da...@alfar.co.uk> ---
Update to report: the bug applies to all logging that uses ap_log_perror().

ErrorLogFormat is not applied when using ap_log_perror(): no server_rec is
passed to log_error_core(), meaning sconf is never set and therefore
sconf->error_log_format not used.

Much more elegant solution than proposed patch is simply to supply
ap_server_core inside ap_log_perror_() in server/log.c:

-    log_error_core(file, line, module_index, level, status, NULL, NULL, NULL,
+    log_error_core(file, line, module_index, level, status, ap_server_core,
NULL, NULL,

(fixes for me)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 55193] ErrorLogFormat is ignored by some modules

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55193

Dave <da...@alfar.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30532|0                           |1
        is obsolete|                            |

--- Comment #2 from Dave <da...@alfar.co.uk> ---
Created attachment 30551
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30551&action=edit
Fix ErrorLogFormat in ap_log_perror()

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


[Bug 55193] ErrorLogFormat is ignored by some modules

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55193

Dave <da...@alfar.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ErrorMessage,
                   |                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org