You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "rgoers (via GitHub)" <gi...@apache.org> on 2023/01/21 06:25:52 UTC

[GitHub] [logging-log4j2] rgoers opened a new pull request, #1218: Use changelog plugin

rgoers opened a new pull request, #1218:
URL: https://github.com/apache/logging-log4j2/pull/1218

   # Licensed to the Apache Software Foundation (ASF) under one or more
   # contributor license agreements. See the NOTICE file distributed with
   # this work for additional information regarding copyright ownership.
   # The ASF licenses this file to You under the Apache License, Version 2.0
   # (the "License"); you may not use this file except in compliance with
   # the License. You may obtain a copy of the License at
   #
   #      http://www.apache.org/licenses/LICENSE-2.0
   #
   # Unless required by applicable law or agreed to in writing, software
   # distributed under the License is distributed on an "AS IS" BASIS,
   # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   # See the License for the specific language governing permissions and
   # limitations under the License.
   
   &lsqb;A clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.&rsqb;
   
   ## Checklist
   
   * `./mvnw verify` succeeds (if it fails due to code formatting issues reported by Spotless, simply run `spotless:apply` and retry)
   * Changes contain an entry file in the `src/changelog/.2.x.x` directory
   * Tests for the changes are provided
   * [Commits are signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) (optional, but highly recommended)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] rgoers closed pull request #1218: Use changelog plugin

Posted by "rgoers (via GitHub)" <gi...@apache.org>.
rgoers closed pull request #1218: Use changelog plugin
URL: https://github.com/apache/logging-log4j2/pull/1218


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] rgoers commented on pull request #1218: Use changelog plugin

Posted by "rgoers (via GitHub)" <gi...@apache.org>.
rgoers commented on PR #1218:
URL: https://github.com/apache/logging-log4j2/pull/1218#issuecomment-1416841750

   I am going to have to close this PR and do it again. With the changes Volkan made to the pom fixing the merge conflicts is too difficult.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1218: Use changelog plugin

Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1218:
URL: https://github.com/apache/logging-log4j2/pull/1218#issuecomment-1417124081

   @rgoers,
   
   The template is in this repo as a hidden file: https://github.com/apache/logging-log4j2/blob/release-2.x/src/changelog/.changelog-entries.adoc.ftl


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] rgoers commented on pull request #1218: Use changelog plugin

Posted by "rgoers (via GitHub)" <gi...@apache.org>.
rgoers commented on PR #1218:
URL: https://github.com/apache/logging-log4j2/pull/1218#issuecomment-1416844127

   @ppkarwasz While I agree with your comments they really belong as an issue int the log4j-tools repo. The template can't be changed here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org