You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/29 21:02:42 UTC
[GitHub] [airflow] blag opened a new pull request, #26788: A few docs fixups
blag opened a new pull request, #26788:
URL: https://github.com/apache/airflow/pull/26788
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Tiny doc fix - rST needs newlines before lists, otherwise it treats them as part of the paragraph.
Should correct a formatting issue when rendered:
Also fixed a few typos around the word 'though' (typo was 'thought'), as well as the grammar around one (correct) usage of the word 'thought'.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #26788: A few docs fixups
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #26788:
URL: https://github.com/apache/airflow/pull/26788#discussion_r984093581
##########
airflow/providers/ssh/hooks/ssh.py:
##########
@@ -50,7 +50,7 @@ class SSHHook(BaseHook):
:param ssh_conn_id: :ref:`ssh connection id<howto/connection:ssh>` from airflow
Connections from where all the required parameters can be fetched like
- username, password or key_file. Thought the priority is given to the
+ username, password or key_file. Though the priority is given to the
param passed during init
Review Comment:
```suggestion
username, password or key_file, though priority is given to the
params passed during init.
```
##########
airflow/providers/microsoft/winrm/hooks/winrm.py:
##########
@@ -40,7 +40,7 @@ class WinRMHook(BaseHook):
:param ssh_conn_id: connection id from airflow Connections from where
all the required parameters can be fetched like username and password.
Review Comment:
```suggestion
all the required parameters can be fetched like username and password,
```
##########
airflow/providers/microsoft/winrm/hooks/winrm.py:
##########
@@ -40,7 +40,7 @@ class WinRMHook(BaseHook):
:param ssh_conn_id: connection id from airflow Connections from where
all the required parameters can be fetched like username and password.
- Thought the priority is given to the param passed during init
+ Though the priority is given to the param passed during init
Review Comment:
```suggestion
though priority is given to the params passed during init.
```
Even better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #26788: A few docs fixups
Posted by GitBox <gi...@apache.org>.
jedcunningham merged PR #26788:
URL: https://github.com/apache/airflow/pull/26788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org