You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/01/03 21:35:34 UTC
Re: Review Request 54073: Added linux launcher nested container
support doc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54073/
-----------------------------------------------------------
(Updated Jan. 3, 2017, 1:35 p.m.)
Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-6335
https://issues.apache.org/jira/browse/MESOS-6335
Repository: mesos
Description
-------
This patch adds a table showing the current semantics
that the linux launcher supports namespaces for nested
container.
Diffs (updated)
-----
docs/containerizer-internals.md 97776a69e5a7df8b65f672a754d456e7b2b90320
Diff: https://reviews.apache.org/r/54073/diff/
Testing
-------
Tested by gist view. Here is the link:
https://github.com/Gilbert88/mesos/blob/doc_pod/docs/containerizer-internals.md#linux-launcher
Thanks,
Gilbert Song
Re: Review Request 54073: Added Linux Namespaces semantic doc.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54073/#review187906
-----------------------------------------------------------
Fix it, then Ship it!
docs/containerizer-internals.md
Lines 152 (patched)
<https://reviews.apache.org/r/54073/#comment264974>
I'd remove not supported
docs/containerizer-internals.md
Lines 157-159 (patched)
<https://reviews.apache.org/r/54073/#comment264973>
This is the current semantics, right? Why TBD and not supported?
docs/containerizer-internals.md
Line 122 (original), 173 (patched)
<https://reviews.apache.org/r/54073/#comment264970>
Not yours, but can you have a link to the isolator lists that we have under `mesos-containerizer.md`
- Jie Yu
On Oct. 13, 2017, 12:23 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54073/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 12:23 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-6335
> https://issues.apache.org/jira/browse/MESOS-6335
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a table showing the current semantics
> that the linux launcher supports namespaces for top
> level and nested container.
>
>
> Diffs
> -----
>
> docs/containerizer-internals.md 5e4f349fbad4429ab7629d0038445d7950787daa
>
>
> Diff: https://reviews.apache.org/r/54073/diff/4/
>
>
> Testing
> -------
>
> Tested by gist view. Here is the link:
>
> https://github.com/Gilbert88/mesos/blob/31f7340976cb71951501bd77c5f6b777c20530e0/docs/containerizer-internals.md#linux-namespaces
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 54073: Added Linux Namespaces semantic doc.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54073/
-----------------------------------------------------------
(Updated Oct. 12, 2017, 5:23 p.m.)
Review request for mesos, Anand Mazumdar, Benjamin Mahler, Artem Harutyunyan, Jie Yu, Neil Conway, Qian Zhang, and Vinod Kone.
Summary (updated)
-----------------
Added Linux Namespaces semantic doc.
Bugs: MESOS-6335
https://issues.apache.org/jira/browse/MESOS-6335
Repository: mesos
Description (updated)
-------
This patch adds a table showing the current semantics
that the linux launcher supports namespaces for top
level and nested container.
Diffs (updated)
-----
docs/containerizer-internals.md 5e4f349fbad4429ab7629d0038445d7950787daa
Diff: https://reviews.apache.org/r/54073/diff/4/
Changes: https://reviews.apache.org/r/54073/diff/3-4/
Testing (updated)
-------
Tested by gist view. Here is the link:
https://github.com/Gilbert88/mesos/blob/31f7340976cb71951501bd77c5f6b777c20530e0/docs/containerizer-internals.md#linux-namespaces
Thanks,
Gilbert Song