You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yiguolei (via GitHub)" <gi...@apache.org> on 2023/03/06 10:17:06 UTC

[GitHub] [doris] yiguolei opened a new pull request, #17461: [refactor](remove string val) remove string val structure, it is same with string ref

yiguolei opened a new pull request, #17461:
URL: https://github.com/apache/doris/pull/17461

   # Proposed changes
   
   1. remove stringval, decimalv2val, bigintval
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17461:
URL: https://github.com/apache/doris/pull/17461#issuecomment-1459120555

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17461:
URL: https://github.com/apache/doris/pull/17461#issuecomment-1459120599

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #17461:
URL: https://github.com/apache/doris/pull/17461#discussion_r1126218842


##########
be/test/util/counts_test.cpp:
##########
@@ -59,7 +59,7 @@ TEST_F(TCountsTest, TotalTest) {
 
     counts.merge(&other1);
     // 1 1 1 1 2 5 7 7 9 9 10 19 50 50 50 99 99 100 100 100
-    EXPECT_EQ(counts.terminate(0.3).val, 6.4);
+    EXPECT_EQ(counts.terminate(0.3), 6.4);

Review Comment:
   warning: member reference base type 'double' is not a structure or union [clang-diagnostic-error]
   ```cpp
       EXPECT_EQ(counts.terminate(0.3).val, 6.4);
                                      ^
   ```
   **thirdparty/installed/include/gtest/gtest.h:2043:** expanded from macro 'EXPECT_EQ'
   ```cpp
     EXPECT_PRED_FORMAT2(::testing::internal::EqHelper::Compare, val1, val2)
                                                                 ^
   ```
   **thirdparty/installed/include/gtest/gtest_pred_impl.h:163:** expanded from macro 'EXPECT_PRED_FORMAT2'
   ```cpp
     GTEST_PRED_FORMAT2_(pred_format, v1, v2, GTEST_NONFATAL_FAILURE_)
                                      ^
   ```
   **thirdparty/installed/include/gtest/gtest_pred_impl.h:148:** expanded from macro 'GTEST_PRED_FORMAT2_'
   ```cpp
     GTEST_ASSERT_(pred_format(#v1, #v2, v1, v2), \
                                         ^
   ```
   **thirdparty/installed/include/gtest/gtest_pred_impl.h:76:** expanded from macro 'GTEST_ASSERT_'
   ```cpp
     if (const ::testing::AssertionResult gtest_ar = (expression)) \
                                                      ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #17461:
URL: https://github.com/apache/doris/pull/17461#issuecomment-1457489301

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 33.53 seconds
    stream load tsv:          455 seconds loaded 74807831229 Bytes, about 156 MB/s
    stream load json:         40 seconds loaded 2358488459 Bytes, about 56 MB/s
    stream load orc:          73 seconds loaded 1101869774 Bytes, about 14 MB/s
    stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230307040351_clickbench_pr_109691.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #17461:
URL: https://github.com/apache/doris/pull/17461#discussion_r1126214752


##########
be/src/exprs/function_filter.h:
##########
@@ -26,7 +26,7 @@ namespace doris {
 class FunctionFilter {
 public:
     FunctionFilter(bool opposite, const std::string& col_name, doris::FunctionContext* fn_ctx,
-                   doris::StringVal string_param)
+                   doris::StringRef string_param)

Review Comment:
   warning: variable has incomplete type 'doris::StringRef' [clang-diagnostic-error]
   ```cpp
                      doris::StringRef string_param)
                                       ^
   ```
   **be/src/udf/udf.h:33:** forward declaration of 'doris::StringRef'
   ```cpp
   struct StringRef;
          ^
   ```
   



##########
be/src/exprs/function_filter.h:
##########
@@ -36,8 +36,8 @@
     std::string _col_name;
     // these pointer's life time controlled by scan node
     doris::FunctionContext* _fn_ctx;
-    doris::StringVal
-            _string_param; // only one param from conjunct, because now only support like predicate
+    // only one param from conjunct, because now only support like predicate
+    doris::StringRef _string_param;

Review Comment:
   warning: field has incomplete type 'doris::StringRef' [clang-diagnostic-error]
   ```cpp
       doris::StringRef _string_param;
                        ^
   ```
   **be/src/udf/udf.h:33:** forward declaration of 'doris::StringRef'
   ```cpp
   struct StringRef;
          ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] Gabriel39 commented on pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref

Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #17461:
URL: https://github.com/apache/doris/pull/17461#issuecomment-1456134905

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei commented on pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #17461:
URL: https://github.com/apache/doris/pull/17461#issuecomment-1457420238

   ./run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #17461: [refactor](remove string val) remove string val structure, it is same with string ref

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #17461:
URL: https://github.com/apache/doris/pull/17461


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org