[GitHub] [incubator-streampark] wangsizhu0504 commented on a diff in pull request #2934: issue-2753 bug fixed.(#2753)

["wangsizhu0504 (via GitHub)" <gi...@apache.org>]

wangsizhu0504 commented on code in PR #2934:
URL: https://github.com/apache/incubator-streampark/pull/2934#discussion_r1292340126


##########
streampark-console/streampark-console-webapp/src/views/flink/app/Detail.vue:
##########
@@ -218,7 +218,7 @@
 
   /* Documentation page */
   function handleDocPage() {
-    const res = window.origin.split(':')[1] + ':10000/doc.html';

Review Comment:
   Would it be better to use the following here ?
   ```js
   const { hostname, protocol } = window.location;
   window.open(`${protocol}//${hostname}:10000/doc.html`);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org