You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/02 23:43:43 UTC

[GitHub] [tvm] NaelsonDouglas opened a new pull request #9435: Removed a manual file handler pitfall

NaelsonDouglas opened a new pull request #9435:
URL: https://github.com/apache/tvm/pull/9435


   **The problem**
   There was a case where the code was using a manual file handler pitfall, where a file stream was being opened and closed manually. But since Python supports automatic stream closing using the block 'with', its better to use it instead of the manual close in order to remove a bug vector.
   
   **Solution**
   Refactored the code to remove the manual file handler


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 merged pull request #9435: Removed a manual file handler pitfall

Posted by GitBox <gi...@apache.org>.
vinx13 merged pull request #9435:
URL: https://github.com/apache/tvm/pull/9435


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 commented on pull request #9435: Removed a manual file handler pitfall

Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9435:
URL: https://github.com/apache/tvm/pull/9435#issuecomment-959831198


   Thanks @NaelsonDouglas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 merged pull request #9435: Removed a manual file handler pitfall

Posted by GitBox <gi...@apache.org>.
vinx13 merged pull request #9435:
URL: https://github.com/apache/tvm/pull/9435






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 commented on pull request #9435: Removed a manual file handler pitfall

Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9435:
URL: https://github.com/apache/tvm/pull/9435#issuecomment-959831198






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 commented on pull request #9435: Removed a manual file handler pitfall

Posted by GitBox <gi...@apache.org>.
vinx13 commented on pull request #9435:
URL: https://github.com/apache/tvm/pull/9435#issuecomment-959831198


   Thanks @NaelsonDouglas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] vinx13 merged pull request #9435: Removed a manual file handler pitfall

Posted by GitBox <gi...@apache.org>.
vinx13 merged pull request #9435:
URL: https://github.com/apache/tvm/pull/9435


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org