[GitHub] [lucene-solr] pawel-bugalski-dynatrace commented on a change in pull request #2429: LUCENE-9791 Allow calling BytesRefHash#find concurrently

[GitBox <gi...@apache.org>]

pawel-bugalski-dynatrace commented on a change in pull request #2429:
URL: https://github.com/apache/lucene-solr/pull/2429#discussion_r583526175



##########
File path: lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java
##########
@@ -31,18 +31,21 @@
  * to the id is encapsulated inside {@link BytesRefHash} and is guaranteed to be increased for each
  * added {@link BytesRef}.
  *
+ * <p><strong>Note that this implementation is not synchronized.</strong> If multiple threads access
+ * a {@link BytesRefHash} instance concurrently, and at least one of the threads modifies it
+ * structurally, it <i>must</i> be synchronized externally. (A structural modification is any
+ * operation on the map except operations explicitly listed in {@link UnmodifiableBytesRefHash}

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org