You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/06 21:40:52 UTC
[GitHub] [trafficserver] ezelkow1 opened a new pull request #8049: Add PS debug to store requesting URL and add to notes
ezelkow1 opened a new pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049
Parent mark down/up does not currently log the url of the request that caused the marking. This makes it hard to debug production issues when you have multiple parents and dest_domains being used, there is not a way currently to know which of them may be having an issue since the URL is not logged.
This adds a reference the requests http string, which is then used in the mark down/up notes that print out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 removed a comment on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 removed a comment on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-938018129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on a change in pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
shinrich commented on a change in pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#discussion_r672607211
##########
File path: proxy/ParentSelection.cc
##########
@@ -126,6 +127,9 @@ ParentConfigParams::findParent(HttpRequestData *rdata, ParentResult *result, uns
tablePtr->Match(rdata, result);
rec = result->rec;
+ // Set the result url string to store the URL request that initiated this
+ result->url = rdata->get_string();
Review comment:
By code inspection, the pointer returned by rdata->get_string() is stable because it is allocated in hdr->url_string_get() which is called from rdata->get_string().
So as the code in this PR stands, things are stable, but you need to add logic to free the result->url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-1011661793
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-938018129
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on a change in pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#discussion_r668314284
##########
File path: proxy/ParentSelection.cc
##########
@@ -126,6 +127,9 @@ ParentConfigParams::findParent(HttpRequestData *rdata, ParentResult *result, uns
tablePtr->Match(rdata, result);
rec = result->rec;
+ // Set the result url string to store the URL request that initiated this
+ result->url = rdata->get_string();
Review comment:
How do you know this pointer is stable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-1047175185
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] closed pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] closed pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-893001914
[approve ci clang-analyzer]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] closed pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-893001914
[approve ci clang-analyzer]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on a change in pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
shinrich commented on a change in pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#discussion_r672607211
##########
File path: proxy/ParentSelection.cc
##########
@@ -126,6 +127,9 @@ ParentConfigParams::findParent(HttpRequestData *rdata, ParentResult *result, uns
tablePtr->Match(rdata, result);
rec = result->rec;
+ // Set the result url string to store the URL request that initiated this
+ result->url = rdata->get_string();
Review comment:
By code inspection, the pointer returned by rdata->get_string() is stable because it is allocated in hdr->url_string_get() which is called from rdata->get_string().
So as the code in this PR stands, things are stable, but you need to add logic to free the result->url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on a change in pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on a change in pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#discussion_r682018606
##########
File path: proxy/ParentSelection.cc
##########
@@ -126,6 +127,9 @@ ParentConfigParams::findParent(HttpRequestData *rdata, ParentResult *result, uns
tablePtr->Match(rdata, result);
rec = result->rec;
+ // Set the result url string to store the URL request that initiated this
+ result->url = rdata->get_string();
Review comment:
getting back to this, Im not sure if there is a good one specific free location, so I figure instead I have to take the approach of storing the rdata ptr and just do get_string/free when I need to use it. So Im testing with that now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-1047172334
[approve ci rocky]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on a change in pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
shinrich commented on a change in pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#discussion_r672607211
##########
File path: proxy/ParentSelection.cc
##########
@@ -126,6 +127,9 @@ ParentConfigParams::findParent(HttpRequestData *rdata, ParentResult *result, uns
tablePtr->Match(rdata, result);
rec = result->rec;
+ // Set the result url string to store the URL request that initiated this
+ result->url = rdata->get_string();
Review comment:
By code inspection, the pointer returned by rdata->get_string() is stable because it is allocated in hdr->url_string_get() which is called from rdata->get_string().
So as the code in this PR stands, things are stable, but you need to add logic to free the result->url.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-938015457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-875735146
> Looks good, you might consider adding this to the NextHop strategies as well since we'll be using that soon. See proxy/http/remap/NextHopHealthStatus.cc in particular.
opened issue #8050 to keep track, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 removed a comment on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 removed a comment on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-938018129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-938015457
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #8049: Add PS debug to store requesting URL and add to notes
Posted by GitBox <gi...@apache.org>.
ezelkow1 commented on pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#issuecomment-916222261
@SolidWallOfCode can you take a look at this again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org