You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2023/11/28 15:03:39 UTC
[PR] on forName validate packages of classes to load [cloudstack]
DaanHoogland opened a new pull request, #8277:
URL: https://github.com/apache/cloudstack/pull/8277
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900224933
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1831471559
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1830141303
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8277?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `11 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`8f39087`)](https://app.codecov.io/gh/apache/cloudstack/commit/8f390873772ef59c3ba81c837fffe707ebd80e72?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 13.11% compared to head [(`b3965d3`)](https://app.codecov.io/gh/apache/cloudstack/pull/8277?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 13.11%.
> Report is 1 commits behind head on 4.18.
| [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...c/main/java/com/cloud/api/ApiSerializerHelper.java](https://app.codecov.io/gh/apache/cloudstack/pull/8277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9BcGlTZXJpYWxpemVySGVscGVyLmphdmE=) | 45.00% | [6 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.18 #8277 +/- ##
=========================================
Coverage 13.11% 13.11%
- Complexity 9133 9135 +2
=========================================
Files 2720 2720
Lines 257645 257658 +13
Branches 40171 40173 +2
=========================================
+ Hits 33800 33804 +4
- Misses 219554 219561 +7
- Partials 4291 4293 +2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8277?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900118389
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2066321544
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2068945094
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900257095
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#discussion_r1408944462
##########
server/src/main/java/com/cloud/api/ApiSerializerHelper.java:
##########
@@ -30,38 +32,51 @@
public class ApiSerializerHelper {
public static final Logger s_logger = Logger.getLogger(ApiSerializerHelper.class.getName());
private static String token = "/";
+ private static String[] apiPackages = {"com.cloud.agent.api", "org.apache.cloudstack.api"};
Review Comment:
yes, it is just an extra layer. They will also have to get those classes on the classpath of the remote machine though. I was think of extending the method to also be able to add a required base class or interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1831474415
@blueorangutan test almo8 kvm-alma8 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1831529493
@DaanHoogland a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2073058660
<b>[SF] Trillian test result (tid-9953)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 108999 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8277-t9953-kvm-centos7.zip
Smoke tests completed. 52 look OK, 58 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 86.73 | test_accounts.py
test_DeleteDomain | `Error` | 17.28 | test_accounts.py
test_forceDeleteDomain | `Failure` | 345.30 | test_accounts.py
test_forceDeleteDomain | `Error` | 345.31 | test_accounts.py
test_01_user_remove_VM_running | `Error` | 83.58 | test_accounts.py
test_01_user_remove_VM_running | `Error` | 83.58 | test_accounts.py
test_03_create_vpc_domain_vpc_offering | `Error` | 57.90 | test_domain_vpc_offerings.py
test_01_events_resource | `Error` | 9.56 | test_events_resource.py
test_01_events_resource | `Error` | 9.57 | test_events_resource.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
test_delete_account | `Error` | 77.00 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 6.47 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 6.47 | test_network.py
test_deploy_vm_l2network | `Error` | 37.51 | test_network.py
test_l2network_restart | `Error` | 9.61 | test_network.py
test_l2network_restart | `Error` | 9.61 | test_network.py
ContextSuite context=TestL2Networks>:teardown | `Error` | 10.72 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 19.23 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 56.94 | test_network.py
test_reboot_router | `Error` | 57.87 | test_network.py
test_releaseIP | `Error` | 10.74 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 19.25 | test_network.py
ContextSuite context=TestSharedNetwork>:setup | `Error` | 19.62 | test_network.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups.py
ContextSuite context=TestAnnotations>:teardown | `Error` | 2.21 | test_annotations.py
test_query_async_job_result | `Error` | 16.49 | test_async_job.py
test_attach_and_distribute_multiple_volumes | `Failure` | 16.95 | test_attach_multiple_volumes.py
test_attach_multiple_volumes | `Failure` | 9.48 | test_attach_multiple_volumes.py
test_attach_multiple_volumes | `Error` | 9.49 | test_attach_multiple_volumes.py
ContextSuite context=TestMultipleVolumeAttach>:teardown | `Error` | 9.74 | test_attach_multiple_volumes.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 543.35 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 53.88 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 249.18 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 249.19 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 52.80 | test_internal_lb.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py
test_02_deploy_vm_with_extraconfig_kvm | `Error` | 7.38 | test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm | `Error` | 135.92 | test_deploy_vm_extra_config_data.py
test_deploy_more_vms_than_limit_allows | `Error` | 110.75 | test_deploy_vms_in_parallel.py
test_deployvm_userconcentrated | `Error` | 7.45 | test_deploy_vms_with_varied_deploymentplanners.py
test_list_vms_metrics_history | `Error` | 7.53 | test_metrics_api.py
test_list_vms_metrics_user | `Error` | 80.10 | test_metrics_api.py
test_list_volumes_metrics_history | `Error` | 7.53 | test_metrics_api.py
test_01_native_to_native_network_migration | `Error` | 110.34 | test_migration.py
test_02_native_to_native_vpc_migration | `Error` | 53.65 | test_migration.py
test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 7.45 | test_direct_download.py
ContextSuite context=TestDirectDownloadTemplates>:teardown | `Error` | 1.07 | test_direct_download.py
test_network_acl | `Error` | 8.40 | test_network_acl.py
test_03_deploy_vm_domain_service_offering | `Error` | 19.14 | test_domain_service_offerings.py
test_updating_nics_on_two_shared_networks | `Error` | 0.04 | test_gateway_on_shared_networks.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3633.79 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3687.65 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 57.53 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 85.19 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 3628.57 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 82.21 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 57.54 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Failure` | 3673.72 | test_kubernetes_clusters.py
test_01_verify_ipv6_network | `Error` | 183.81 | test_network_ipv6.py
test_01_verify_ipv6_network | `Error` | 183.82 | test_network_ipv6.py
ContextSuite context=TestIpv6Network>:teardown | `Error` | 218.79 | test_network_ipv6.py
test_03_network_operations_on_created_vm_of_otheruser | `Failure` | 86.00 | test_network_permissions.py
test_03_network_operations_on_created_vm_of_otheruser | `Error` | 86.01 | test_network_permissions.py
test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 65.97 | test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.39 | test_network_permissions.py
test_01_nic | `Error` | 113.63 | test_nic.py
test_01_non_strict_host_anti_affinity | `Error` | 0.09 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 0.03 | test_nonstrict_affinity_group.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
test_01_isolated_persistent_network | `Error` | 6.40 | test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Error` | 0.04 | test_persistent_network.py
ContextSuite context=TestL2PersistentNetworks>:teardown | `Error` | 0.14 | test_persistent_network.py
test_01_create_delete_portforwarding_fornonvpc | `Error` | 100.18 | test_portforwardingrules.py
test_01_add_primary_storage_disabled_host | `Error` | 35.20 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.16 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.28 | test_primary_storage.py
test_01_vpc_privategw_acl | `Failure` | 10.34 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 13.44 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 7.29 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 14.46 | test_privategw_acl.py
test_09_project_suspend | `Error` | 8.50 | test_projects.py
test_10_project_activation | `Error` | 13.59 | test_projects.py
test_deploy_vm_with_registered_userdata | `Error` | 3.82 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 4.62 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 4.54 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params | `Error` | 4.49 | test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_sys_vm_start | `Failure` | 0.13 | test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.22 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.04 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
test_09_reboot_ssvm_forced | `Failure` | 0.04 | test_ssvm.py
test_10_reboot_cpvm_forced | `Failure` | 0.03 | test_ssvm.py
test_11_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
test_12_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.44 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.43 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.44 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.51 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.33 | test_templates.py
ContextSuite context=TestCreateTemplateWithDirectDownload>:teardown | `Error` | 15.95 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 21.99 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmAutoScaling>:setup | `Error` | 0.00 | test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host | `Error` | 1.30 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 1.30 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 1.31 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.29 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.26 | test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 85.56 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 231.47 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 122.98 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 122.98 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 0.02 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 3.38 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 3.69 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 5.10 | test_volumes.py
ContextSuite context=TestIpv6Vpc>:setup | `Error` | 0.00 | test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1.55 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 1.62 | test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Failure` | 12.51 | test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Failure` | 12.56 | test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Failure` | 23.59 | test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:teardown | `Error` | 24.72 | test_host_maintenance.py
test_disable_oobm_ha_state_ineligible | `Error` | 1512.93 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900257606
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2066309608
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2066323335
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#discussion_r1408895188
##########
server/src/main/java/com/cloud/api/ApiSerializerHelper.java:
##########
@@ -30,38 +32,51 @@
public class ApiSerializerHelper {
public static final Logger s_logger = Logger.getLogger(ApiSerializerHelper.class.getName());
private static String token = "/";
+ private static String[] apiPackages = {"com.cloud.agent.api", "org.apache.cloudstack.api"};
Review Comment:
I am not sure if this will improve security (is it the goal of this PR ?).
anyone can create java classes in the packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1901453628
<b>[SF] Trillian test result (tid-8885)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45317 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8277-t8885-kvm-centos7.zip
Smoke tests completed. 105 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
test_01_non_strict_host_anti_affinity | `Error` | 0.08 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 0.02 | test_nonstrict_affinity_group.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 829.15 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2069137713
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2066200931
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1831383853
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#discussion_r1410366385
##########
server/src/main/java/com/cloud/api/ApiSerializerHelper.java:
##########
@@ -30,38 +32,51 @@
public class ApiSerializerHelper {
public static final Logger s_logger = Logger.getLogger(ApiSerializerHelper.class.getName());
private static String token = "/";
+ private static String[] apiPackages = {"com.cloud.agent.api", "org.apache.cloudstack.api"};
Review Comment:
> I am not sure if this will improve security (is it the goal of this PR ?). anyone can create java classes in the packages
any sugestions for improvement @weizhouapache ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1831477039
@DaanHoogland [SL] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2069133249
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2066434118
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1832911869
<b>[SF] Trillian test result (tid-8426)</b>
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 51971 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8277-t8426-kvm-alma8.zip
Smoke tests completed. 104 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | test_affinity_groups_projects.py
test_01_non_strict_host_anti_affinity | `Error` | 0.09 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 0.04 | test_nonstrict_affinity_group.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3622.08 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3610.78 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Failure` | 48.27 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 106.14 | test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume | `Error` | 84.35 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 51.80 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 0.07 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2066199506
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2068940990
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2069074158
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1831528326
@blueorangutan test alma8 kvm-alma8 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1831383182
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-1900132351
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] on forName validate packages of classes to load [cloudstack]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8277:
URL: https://github.com/apache/cloudstack/pull/8277#issuecomment-2066200651
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8277?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `45.00000%` with `11 lines` in your changes are missing coverage. Please review.
> Project coverage is 13.11%. Comparing base [(`f731fe8`)](https://app.codecov.io/gh/apache/cloudstack/commit/f731fe882c5b8459a14da9a13269a8360df2743e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b3965d3`)](https://app.codecov.io/gh/apache/cloudstack/pull/8277?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 24 commits behind head on 4.18.
> :exclamation: Current head b3965d3 differs from pull request most recent head 4805e80. Consider uploading reports for the commit 4805e80 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8277?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...c/main/java/com/cloud/api/ApiSerializerHelper.java](https://app.codecov.io/gh/apache/cloudstack/pull/8277?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fapi%2FApiSerializerHelper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2FwaS9BcGlTZXJpYWxpemVySGVscGVyLmphdmE=) | 45.00% | [6 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.18 #8277 +/- ##
============================================
- Coverage 13.16% 13.11% -0.05%
+ Complexity 9203 9135 -68
============================================
Files 2724 2720 -4
Lines 258130 257658 -472
Branches 40232 40173 -59
============================================
- Hits 33989 33804 -185
+ Misses 219833 219561 -272
+ Partials 4308 4293 -15
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8277?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org