[GitHub] [ozone] Xushaohong commented on a diff in pull request #4590: HDDS-8261. Fail integration tests if RocksDB objects are leaked

["Xushaohong (via GitHub)" <gi...@apache.org>]

Xushaohong commented on code in PR #4590:
URL: https://github.com/apache/ozone/pull/4590#discussion_r1172553367


##########
hadoop-ozone/dev-support/checks/_mvn_unit_report.sh:
##########
@@ -60,9 +69,12 @@ if grep -q 'There was a timeout.*in the fork' "${REPORT_DIR}/output.log"; then
       | sort -u -k2) \
     | grep '^- ' \
     | awk '{ print $3 }' \
-    | tee -a "${REPORT_DIR}/summary.txt"
+    >> "${tempfile}"
 fi
 
+sort -u "${tempfile}" | tee "${REPORT_DIR}/summary.txt"
+rm "${tempfile}"

Review Comment:
   Seems ${tempfile} might not exist, shall we use `rm -f ` to omit the possible error msg?



##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBTableStore.java:
##########
@@ -428,9 +428,10 @@ public void testIteratorRemoveFromDB() throws Exception {
     // Remove without next removes first entry.
     try (Table<byte[], byte[]> testTable = rdbStore.getTable("Fifth")) {
       writeToTable(testTable, 3);
-      TableIterator<byte[], ? extends Table.KeyValue<byte[], byte[]>> iterator =
-          testTable.iterator();
-      iterator.removeFromDB();
+      try (TableIterator<?, ? extends Table.KeyValue<?, ?>> iterator =

Review Comment:
   Just curious. Why does this patch replace many explicit type declarations with wildcards? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org