You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by pubudu538 <gi...@git.apache.org> on 2015/06/29 05:43:33 UTC
[GitHub] stratos pull request: Fixed listing cartridge groups in cli
GitHub user pubudu538 opened a pull request:
https://github.com/apache/stratos/pull/379
Fixed listing cartridge groups in cli
- Could not list down cartridge groups as "scalingDependents" was missing from cxf-servlet.xml
- Changed error messages to have more details
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pubudu538/stratos fix-listcg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/379.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #379
----
commit f68d2eac4317067b9e42740927e42c4da45e27af
Author: Pubudu Gunatilaka <pu...@gmail.com>
Date: 2015-06-29T03:37:19Z
fixed listing cartridge groups in cli
commit 569c350b8a41b146bd1deea15e7c90795bae1faf
Author: Pubudu Gunatilaka <pu...@gmail.com>
Date: 2015-06-29T03:42:02Z
fixed error message minor issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Fixed listing cartridge groups in cli
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on the pull request:
https://github.com/apache/stratos/pull/379#issuecomment-116433100
Thanks for the fix Pubudu!! I have now merged this pull request to master branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Fixed listing cartridge groups in cli
Posted by dinusha-dilrukshi <gi...@git.apache.org>.
Github user dinusha-dilrukshi commented on a diff in the pull request:
https://github.com/apache/stratos/pull/379#discussion_r46131587
--- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java ---
@@ -127,10 +127,10 @@ public static void addCartridge(CartridgeBean cartridgeBean) throws RestAPIExcep
cartridgeBean.getType()));
}
- for(PortMappingBean portMapping : cartridgeBean.getPortMapping()) {
- if(StringUtils.isBlank(portMapping.getName())) {
+ for (PortMappingBean portMapping : cartridgeBean.getPortMapping()) {
+ if (StringUtils.isBlank(portMapping.getName())) {
portMapping.setName(portMapping.getProtocol() + "-" + portMapping.getPort());
- if(log.isInfoEnabled()) {
+ if (log.isInfoEnabled()) {
--- End diff --
Seems you have fixed only formatting issue here. Anyway, default carbon log level is set to "INFO", hence checking isInfoEnabled() introduce additional cost if it's same with org.apache.stratos too. Better check it and remove.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Fixed listing cartridge groups in cli
Posted by pubudu538 <gi...@git.apache.org>.
Github user pubudu538 commented on a diff in the pull request:
https://github.com/apache/stratos/pull/379#discussion_r46133085
--- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java ---
@@ -127,10 +127,10 @@ public static void addCartridge(CartridgeBean cartridgeBean) throws RestAPIExcep
cartridgeBean.getType()));
}
- for(PortMappingBean portMapping : cartridgeBean.getPortMapping()) {
- if(StringUtils.isBlank(portMapping.getName())) {
+ for (PortMappingBean portMapping : cartridgeBean.getPortMapping()) {
+ if (StringUtils.isBlank(portMapping.getName())) {
portMapping.setName(portMapping.getProtocol() + "-" + portMapping.getPort());
- if(log.isInfoEnabled()) {
+ if (log.isInfoEnabled()) {
--- End diff --
Thank you for pointing this out. Will remove that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Fixed listing cartridge groups in cli
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/stratos/pull/379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---