You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/05/20 02:19:18 UTC
[GitHub] [james-project] Arsnael commented on a change in pull request #440: [PERFORMANCE] Cache and reuse Object mappers for writing JMAP responses
Arsnael commented on a change in pull request #440:
URL: https://github.com/apache/james-project/pull/440#discussion_r635699936
##########
File path: server/protocols/jmap-draft-integration-testing/jmap-draft-integration-testing-common/src/test/java/org/apache/james/jmap/draft/methods/integration/SendMDNMethodTest.java
##########
@@ -296,8 +296,8 @@ void sendMDNShouldSendAMDNBackToTheOriginalMessageAuthor() {
" \"type\":\"processed\"" +
" }" +
"}" +
- "}}, \"#0\"]]")
- .post("/jmap");
+ "}}, \"#0\"]]").log().all()
+ .post("/jmap").prettyPeek();
Review comment:
debug spotted
##########
File path: server/protocols/jmap-draft-integration-testing/jmap-draft-integration-testing-common/src/test/java/org/apache/james/jmap/draft/methods/integration/SendMDNMethodTest.java
##########
@@ -344,16 +344,16 @@ void sendMDNShouldPositionTheReportAsAnAttachment() {
" }" +
"}" +
"}}, \"#0\"]]")
- .post("/jmap");
+ .post("/jmap").prettyPeek();
// BART should have received it
calmlyAwait.until(() -> !listMessageIdsInMailbox(bartAccessToken, getInboxId(bartAccessToken)).isEmpty());
List<String> bobInboxMessageIds = listMessageIdsInMailbox(bartAccessToken, getInboxId(bartAccessToken));
- String blobId = with()
+ String blobId = with().log().all()
.header("Authorization", bartAccessToken.asString())
.body("[[\"getMessages\", {\"ids\": [\"" + bobInboxMessageIds.get(0) + "\"]}, \"#0\"]]")
- .post("/jmap")
+ .post("/jmap").prettyPeek()
Review comment:
idem
##########
File path: server/protocols/jmap-draft-integration-testing/jmap-draft-integration-testing-common/src/test/java/org/apache/james/jmap/draft/methods/integration/SendMDNMethodTest.java
##########
@@ -330,7 +330,7 @@ void sendMDNShouldPositionTheReportAsAnAttachment() {
// USER sends a MDN back to BART
String creationId = "creation-1";
with()
- .header("Authorization", homerAccessToken.asString())
+ .header("Authorization", homerAccessToken.asString()).log().all()
Review comment:
is that considered as debug too?
##########
File path: server/protocols/jmap-draft-integration-testing/jmap-draft-integration-testing-common/src/test/java/org/apache/james/jmap/draft/methods/integration/SendMDNMethodTest.java
##########
@@ -306,9 +306,9 @@ void sendMDNShouldSendAMDNBackToTheOriginalMessageAuthor() {
String firstMessage = ARGUMENTS + ".list[0]";
given()
.header("Authorization", bartAccessToken.asString())
- .body("[[\"getMessages\", {\"ids\": [\"" + bartInboxMessageIds + "\"]}, \"#0\"]]")
+ .body("[[\"getMessages\", {\"ids\": [\"" + bartInboxMessageIds + "\"]}, \"#0\"]]").log().all()
.when()
- .post("/jmap")
+ .post("/jmap").prettyPeek()
Review comment:
debug spotted
##########
File path: server/protocols/jmap-draft-integration-testing/jmap-draft-integration-testing-common/src/test/java/org/apache/james/jmap/draft/methods/integration/SendMDNMethodTest.java
##########
@@ -344,16 +344,16 @@ void sendMDNShouldPositionTheReportAsAnAttachment() {
" }" +
"}" +
"}}, \"#0\"]]")
- .post("/jmap");
+ .post("/jmap").prettyPeek();
Review comment:
idem
##########
File path: server/protocols/jmap-draft-integration-testing/jmap-draft-integration-testing-common/src/test/java/org/apache/james/jmap/draft/methods/integration/SendMDNMethodTest.java
##########
@@ -344,16 +344,16 @@ void sendMDNShouldPositionTheReportAsAnAttachment() {
" }" +
"}" +
"}}, \"#0\"]]")
- .post("/jmap");
+ .post("/jmap").prettyPeek();
// BART should have received it
calmlyAwait.until(() -> !listMessageIdsInMailbox(bartAccessToken, getInboxId(bartAccessToken)).isEmpty());
List<String> bobInboxMessageIds = listMessageIdsInMailbox(bartAccessToken, getInboxId(bartAccessToken));
- String blobId = with()
+ String blobId = with().log().all()
Review comment:
idem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org