You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/02/01 22:52:19 UTC
[GitHub] mgaido91 commented on issue #141: [LIVY-551] Add "doAs"
impersonation support
mgaido91 commented on issue #141: [LIVY-551] Add "doAs" impersonation support
URL: https://github.com/apache/incubator-livy/pull/141#issuecomment-459895356
@risdenk yes, that is the right place for sure, but since this parameter is valid for all the endpoints, I am not sure whether to create a new section for common parameters having this single one for the moment or do something else. So I'd like to hear if someone has a good/strong opinion on this.
The code itself now looks good to me. The only point I think still need to be addressed is the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services