[GitHub] srkukarni closed pull request #2668: Python Functions support topic pattern, so removing this check

[GitBox <gi...@apache.org>]

srkukarni closed pull request #2668: Python Functions support topic pattern, so removing this check
URL: https://github.com/apache/pulsar/pull/2668
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
index 030a5a7125..adb4578109 100644
--- a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
+++ b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
@@ -68,12 +68,6 @@ public void start() throws Exception {
         log.info("{}/{}/{}-{} RuntimeSpawner starting function", details.getTenant(), details.getNamespace(),
                 details.getName(), this.instanceConfig.getInstanceId());
 
-        if (instanceConfig.getFunctionDetails().getRuntime() == PYTHON
-                && instanceConfig.getFunctionDetails().getSource() != null
-                && StringUtils.isNotBlank(instanceConfig.getFunctionDetails().getSource().getTopicsPattern())) {
-            throw new IllegalArgumentException("topics-pattern is not supported for python function");
-        }
-
         runtime = runtimeFactory.createContainer(this.instanceConfig, codeFile,
                 instanceLivenessCheckFreqMs * 1000);
         runtime.start();


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services