You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/10 07:41:26 UTC

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #451: feat(route): add publish and offline to route

membphis commented on a change in pull request #451:
URL: https://github.com/apache/apisix-dashboard/pull/451#discussion_r486130770



##########
File path: src/pages/Route/typing.d.ts
##########
@@ -113,6 +116,7 @@ declare namespace RouteModule {
   // Request Body or Response Data for API
   type Body = {
     id?: number;
+    status: boolean;

Review comment:
       do we need to add a boolean flag in route? 
   
   https://github.com/apache/apisix/blob/master/doc/admin-api.md#route
   
   we'll remove mysql soon.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org