You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/01/26 01:22:27 UTC
[GitHub] [incubator-gobblin] autumnust opened a new pull request #3213: [GOBBLIN-1372] Generalization of GobblinClusterUtils#setSystemProperties
autumnust opened a new pull request #3213:
URL: https://github.com/apache/incubator-gobblin/pull/3213
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
https://issues.apache.org/jira/browse/GOBBLIN-1372
### Description
This PR mainly is for refactoring the method `GobblinClusterUtils#setSystemProperties`. The problem was: There are some unnecessary details being exposed: `JAVA_TMP_DIR_KEY` and resolution of `YARN_CACHE` are all very specific to Gobblin-on-YARN applications. These things shouldn't be set through if-branch but through configurations only.
After refactoring:
There's no specific key/value matching within `setSystemProperties` method, and we don't lose the capability for limiting resolution of `YARN_CACHE` only for a specific set of configuration with being backward-compatible.
Also, the refactor also let the program to set additional configuration with value specified as `YARN_CACHE` using the following pairs:
```
gobblin.cluster.systemPropertiesList.YARN_CACHE=grape.root
gobblin.cluster.sysProps.grape.root=YARN_CACHE
```
If trying to achieve the same purpose as `-Dgrape.root=YARN_CACHE`
Also, it adds a bunch of entries in the .gitignore file.
### Tests
Unit tested with resolution cases.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on pull request #3213: [GOBBLIN-1372] Generalization of GobblinClusterUtils#setSystemProperties
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #3213:
URL: https://github.com/apache/incubator-gobblin/pull/3213#issuecomment-767218525
@sv2000 @Will-Lo Please help take a look, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] autumnust commented on pull request #3213: [GOBBLIN-1372] Generalization of GobblinClusterUtils#setSystemProperties
Posted by GitBox <gi...@apache.org>.
autumnust commented on pull request #3213:
URL: https://github.com/apache/incubator-gobblin/pull/3213#issuecomment-767218525
@sv2000 @Will-Lo Please help take a look, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3213: [GOBBLIN-1372] Generalization of GobblinClusterUtils#setSystemProperties
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3213:
URL: https://github.com/apache/incubator-gobblin/pull/3213#issuecomment-767291856
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=h1) Report
> Merging [#3213](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=desc) (6a263e7) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/f4c75139bf38b73b3fc052cc5c2010cdca9bc4c0?el=desc) (f4c7513) will **increase** coverage by `32.72%`.
> The diff coverage is `92.30%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3213 +/- ##
=============================================
+ Coverage 9.17% 41.89% +32.72%
- Complexity 1738 8908 +7170
=============================================
Files 2019 2019
Lines 77506 77524 +18
Branches 8607 8610 +3
=============================================
+ Hits 7109 32477 +25368
+ Misses 69701 41985 -27716
- Partials 696 3062 +2366
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/gobblin/cluster/GobblinClusterUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJVdGlscy5qYXZh) | `87.03% <92.30%> (+34.25%)` | `13.00 <5.00> (+4.00)` | |
| [.../org/apache/gobblin/util/filters/HiddenFilter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsdGVycy9IaWRkZW5GaWx0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...g/apache/gobblin/cluster/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../gobblin/compaction/suite/CompactionSuiteBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvblN1aXRlQmFzZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...obblin/compaction/source/CompactionFailedTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc291cmNlL0NvbXBhY3Rpb25GYWlsZWRUYXNrLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...n/cluster/event/ClusterManagerShutdownRequest.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvZXZlbnQvQ2x1c3Rlck1hbmFnZXJTaHV0ZG93blJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...blin/compaction/mapreduce/RecordKeyMapperBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL1JlY29yZEtleU1hcHBlckJhc2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...in/compaction/action/CompactionCompleteAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25Db21wbGV0ZUFjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...n/compaction/mapreduce/orc/OrcKeyDedupReducer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNLZXlEZWR1cFJlZHVjZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [1176 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3213/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=footer). Last update [f4c7513...6a263e7](https://codecov.io/gh/apache/incubator-gobblin/pull/3213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3213: [GOBBLIN-1372] Generalization of GobblinClusterUtils#setSystemProperties
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3213:
URL: https://github.com/apache/incubator-gobblin/pull/3213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org