You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by MJJoyce <gi...@git.apache.org> on 2015/03/18 19:40:47 UTC
[GitHub] climate pull request: CLIMATE-607 - Fix breaking config parser tes...
GitHub user MJJoyce opened a pull request:
https://github.com/apache/climate/pull/178
CLIMATE-607 - Fix breaking config parser tests
- A previous change split the various config parsing components out into
separate modules. The config parser import name was changed in the
test_config_parsing tests module but the actual call to the new import
was not.
- One of the logger mocks incorrectly referenced the old module name.
This was causing the mocking library to not recognize that the correct
logging function was in fact being called.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MJJoyce/climate CLIMATE-607
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #178
----
commit 4c6d8366577a9940d73667c4bd2d235aaefbd748
Author: Michael Joyce <jo...@apache.org>
Date: 2015-03-18T18:34:09Z
CLIMATE-607 - Fix breaking config parser tests
- A previous change split the various config parsing components out into
separate modules. The config parser import name was changed in the
test_config_parsing tests module but the actual call to the new import
was not.
- One of the logger mocks incorrectly referenced the old module name.
This was causing the mocking library to not recognize that the correct
logging function was in fact being called.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-607 - Fix broken config parser tests
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/178#issuecomment-83117009
Merged build started. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-607 - Fix broken config parser tests
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/178#issuecomment-83117251
Merged build finished. Test Passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-607 - Fix broken config parser tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/climate/pull/178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] climate pull request: CLIMATE-607 - Fix broken config parser tests
Posted by OCWJenkins <gi...@git.apache.org>.
Github user OCWJenkins commented on the pull request:
https://github.com/apache/climate/pull/178#issuecomment-83116963
Merged build triggered. Test Failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---