[GitHub] [superset] zhaoyongjie commented on a diff in pull request #20063: fix : add locale to activate french translation for DatePicker component

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #20063:
URL: https://github.com/apache/superset/pull/20063#discussion_r872942176


##########
superset-frontend/src/explore/components/controls/DateFilterControl/components/CustomFrame.tsx:
##########
@@ -132,6 +139,7 @@ export function CustomFrame(props: FrameComponentProps) {
                   onChange('sinceDatetime', datetime.format(MOMENT_FORMAT))
                 }
                 allowClear={false}
+                locale={locale}

Review Comment:
   Thanks for the contribution! Could we make translation more generic? For example, we can define a map constant that mapping from `bootstrapData.common.local` to the `antd locale`. feel free to leave messages if you need help.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org