[GitHub] [accumulo] milleruntime commented on a change in pull request #1751: WIP Design: Interface for handling tablet state migration

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1751:
URL: https://github.com/apache/accumulo/pull/1751#discussion_r512121378



##########
File path: server/manager/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java
##########
@@ -244,6 +246,7 @@ public void run() {
             }

Review comment:
       With this design, the "Always follow through with assignments" check would not need to exist, they would have this logic built into the types. For example, ```AssignedTabletHostedGoal``` is the only class that has a current state of ```ASSIGNED```. 
   
   I am not sure what this second check is trying to do... something with ordering during shutdown of the whole cluster?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org