You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2021/02/04 14:55:17 UTC
[GitHub] [avro] RyanSkraba commented on pull request #973: AVRO-2952: AvroDatatype
RyanSkraba commented on pull request #973:
URL: https://github.com/apache/avro/pull/973#issuecomment-773369646
Hello! I haven't had the time to attack this PR. There's a lot of lines of code, and thanks so much to @unchuckable for picking up the slack on the peer review -- great job, your opinion is welcomed and valued! @wernerdaehn of course, I also appreciate your openness, patience and willingness to contribute your work!
I have some concerns about the interactions between the new AvroDatatype interface being introduced and the existing Conversions, as well as existing non-standard user-defined LogicalTypes -- I really need to give this a thorough read to better understand. With my time constraints, I can commit to doing a read through and discussion in the next week!
I would love to have any other committers weigh in, especially if anyone has any ideas or experience on making big changes less daunting. I don't want to make *more* work for you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org