You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/10 07:12:08 UTC
[GitHub] [superset] mistercrunch opened a new pull request #16163: chore: remove TerserPlugin step for build
mistercrunch opened a new pull request #16163:
URL: https://github.com/apache/superset/pull/16163
### SUMMARY
Trying webpack without `TerserPlugin`, there doesn't seem to be any impact on the bundle size, yet we save a bunch of cpu time on the `npm run build` step. To be fair, when I don't remove the `.terser-plugin-cache/`, the difference is minimal, but assuming docker isn't doing anything special to keep that cache active, in that context, or in the context of a new env, the hit is pretty significant. This only affect `npm run build` but could shave a few minutes from some of our builds.
```
## Methodology
```
# timing with
$ time npm run build
# cleanup
$ rm -rf .terser-plugin-cache/
$ rm -rf ../superset/static/assets/*
```
## With Terser
```
$ du -sh ../superset/static/assets/
54M ../superset/static/assets/
# first run
real 2m17.742s
user 9m2.984s
sys 0m50.677s
# second run
real 2m31.410s
user 9m16.850s
sys 0m47.766s
```
## Without Terser
```
$ rm .terser*
$ du -sh ../superset/static/assets/
54M ../superset/static/assets/
# first run
real 1m12.785s
user 3m50.063s
sys 0m26.636s
# second run
real 1m35.231s
user 4m54.031s
sys 0m38.375s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16163: chore: remove TerserPlugin step for build
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16163:
URL: https://github.com/apache/superset/pull/16163#issuecomment-895801730
# [Codecov](https://codecov.io/gh/apache/superset/pull/16163?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16163](https://codecov.io/gh/apache/superset/pull/16163?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4e95aa) into [master](https://codecov.io/gh/apache/superset/commit/3712ee02fa8a3229fc1bc7115c853e66c6ea5261?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3712ee0) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/16163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16163 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 996 996
Lines 52942 52942
Branches 6734 6734
=======================================
Hits 40668 40668
Misses 12049 12049
Partials 225 225
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.19% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16163?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16163?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3712ee0...e4e95aa](https://codecov.io/gh/apache/superset/pull/16163?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #16163: chore: remove TerserPlugin step for build
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #16163:
URL: https://github.com/apache/superset/pull/16163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org