RE: [httpclient] More HttpMultiClient patches - initial strict m ode stuff

[Marc Saegesser <Ma...@apropos.com>]

Now that I've got karma on jakarta-commons I'll take care of merging the
changes into cvs.  One of the problems with doing large scale patches is
that they can become stale quickly.  It'll be easier for me to do the merge
since I made the changes.

I'll also add some additional test cases for the new code.  


Marc Saegesser 

> -----Original Message-----
> From: Marc Paquette [mailto:mpaquett@covansys.com]
> Sent: Wednesday, February 20, 2002 9:31 AM
> To: Jakarta Commons Developers List
> Subject: Re: [httpclient] More HttpMultiClient patches - 
> initial strict
> m ode stuff
> 
> 
> 
> 
> Marc Saegesser wrote:
> 
> >I haven't had a chance to look at the existing test cases in 
> depth yet.  I
> >should be able to duplicate the existing test cases for the 
> HttpMethod based
> >stuff into tests for the HttpUrlMethod classes without much 
> trouble.  I'll
> >see what I can do.  
> >
> >The other stuff is a little harder to test.  For example, 
> testing the 100
> >status respose thing requires finding a server that 
> repeatably sends the
> >response at the unexpected time.  The only one I have right 
> now is my online
> >banking site and I'm not posting my username/password for 
> that site into the
> >test cases :-)  Same thing for the broken relative Location header.  
> >
> >As for time to deal with this stuff.  I've been a 
> jakarta-tomcat committer
> >for over year.  I worked primarily on the 3.2.x stuff and 
> since that's now
> >over I've got time to spend elsewhere.  Since I'm working heavily on
> >HttpClient for my own application I'd be more than happy to 
> help out around
> >here if the other committers will have me.
> >
> I've tried to apply you patches, but they had conflicts with 
> the latest 
> (as of yesterday) codebase (mostly because calling log.debug() is now 
> conditional on log.isDebugEnabled()).  Also, I'v subscribed 
> to this list 
> between your first set of patches and the latest one for 
> HttpMultiClient, therefore I'm missing half the stuff :-(  If the 
> patches as a whole, coherent set against the latest codebase could be 
> supplied, it would be easier to try it (at least for me).
> 
> >
> >
> >
> >Marc Saegesser 
> >
> >>-----Original Message-----
> >>From: dIon Gillard [mailto:dion@multitask.com.au]
> >>Sent: Tuesday, February 19, 2002 4:39 PM
> >>To: Jakarta Commons Developers List
> >>Subject: Re: [httpclient] More HttpMultiClient patches - 
> >>initial strict
> >>mode stuff
> >>
> >>
> >>Marc Saegesser wrote:
> >>
> >>>The attached are three patches that update my previous 
> >>>
> >>patches for the
> >>
> >>>HttpMultiClient stuff.
> >>>
> >>>HttpMethodBase.java - Fixes a bug I created when I tried to 
> >>>
> >>fix the broken
> >>
> >>>handling of a 100 status codes.  I had this working 
> >>>
> >>correctly once, but due
> >>
> >>>to sever fumble fingered-ness I trashed it.  When I 
> >>>
> >>re-implemented it I did
> >>
> >>>it wrong.  Anywhere, this version handes 100 status codes 
> >>>
> >>correctly.  I also
> >>
> >>>added some preliminary support for 
> >>>
> >>StrictMode/Non-StrictMode.  This is the
> >>
> >>>stuff I was talking about before where we need to support 
> sites that
> >>>implement HTTP incorrectly.  The first case I've dealt with 
> >>>
> >>is a site that
> >>
> >>>returns a relative path in the Location header for a 
> >>>
> >>redirect.  If strict
> >>
> >>>mode is not enabled I attempt to build a new URL in the 
> >>>
> >>context of the
> >>
> >>>current request.
> >>>
> >>>HttpMethod.java - Added accessor methods for strictMode.
> >>>
> >>>HttpMultiClient.java - Added accessor methods for 
> >>>
> >>strictMode.  Updated
> >>
> >>>executeMethod() to set the strictMode for each request.
> >>>
> >>>
> >>>Marc Saegesser 
> >>>
> >>Hi Marc,
> >>
> >>just to let you know, I'm digesting the original patches you 
> >>made, but 
> >>given HttpClient isn't my full time thing, it's taking a 
> >>while. Do you 
> >>have any test cases for the patches/new functionality that 
> >>can be used 
> >>to verify the code?
> >>
> >>That sort of stuff would help me enormously.
> >>
> >>>     
> >>>
> >>-- 
> >>
> >>dIon Gillard, Multitask Consulting
> >>http://www.multitask.com.au/developers
> >>
> >>
> >>
> >>
> >>--
> >>To unsubscribe, e-mail:   
> >><ma...@jakarta.apache.org>
> >>For additional commands, e-mail: 
> >><ma...@jakarta.apache.org>
> >>
> >
> >--
> >To unsubscribe, e-mail:   
<ma...@jakarta.apache.org>
>For additional commands, e-mail:
<ma...@jakarta.apache.org>
>

-- 

Marc Paquette
Conseiller Principal, Architecture de solutions, WEI
Tel: 514-288-4680 x2028 (boite vocale: 8008)
mpaquett@covansys.com




--
To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
For additional commands, e-mail:
<ma...@jakarta.apache.org>

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: [httpclient] More HttpMultiClient patches - initial strict m ode stuff

[dIon Gillard <di...@multitask.com.au>]

Marc Saegesser wrote:

>Now that I've got karma on jakarta-commons I'll take care of merging the
>changes into cvs.  One of the problems with doing large scale patches is
>that they can become stale quickly.  It'll be easier for me to do the merge
>since I made the changes.
>
>I'll also add some additional test cases for the new code.  
>
>
>Marc Saegesser 
>
Cool, makes my life easier :)

-- 
dIon Gillard, Multitask Consulting
http://www.multitask.com.au/developers




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>