You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/02 17:13:41 UTC
[GitHub] [arrow] mbrobbel opened a new pull request #12322: ARROW-15533: [C++] ARROW_WITH_OPENTELEMETRY is not checked in CI
mbrobbel opened a new pull request #12322:
URL: https://github.com/apache/arrow/pull/12322
- Set `ARROW_WITH_OPENTELEMETRY: ON` in C++ GitHub Actions workflow
- Add default value for ExecNode::ToStringExtra argument indent argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028896557
Revision: 02edcb83f203b7e0fdcad7a22d550e001ba4ba72
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1572](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1572)
|Task|Status|
|----|------|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-build-cpp-fuzz)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1572-azure-test-conda-cpp-valgrind)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-debian-10-cpp-amd64)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-debian-10-cpp-i386)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-debian-11-cpp-amd64)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-debian-11-cpp-i386)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-fedora-33-cpp)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-ubuntu-20.04-cpp-bundled)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-21.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1572-github-test-ubuntu-21.04-cpp)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005
Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca9d32e0724cd245c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/732dc06332604b5f9b325af50f8dece5...fa793d990b4a42ab87a1ff813475e710/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/904e7917b8954329beeef50209a97232...ab07e005b43d4821a4b228818bfe0146/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c5bbbeb6853842e0921b872d4958ee84...ec29c66cfce149dbb083c695d95b0ad5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mbrobbel commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
mbrobbel commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1029924797
> The "python-sdist" nightly build started failing (see https://github.com/ursacomputing/crossbow/runs/5062761297?check_suite_focus=true), with a message that seems related to OpenTelemetry:
>
> ```
> -- stderr output is:
> CMake Error at /usr/share/cmake-3.16/Modules/ExternalProject.cmake:2421 (message):
> error: could not find git for clone of opentelemetry-proto
> Call Stack (most recent call first):
> /usr/share/cmake-3.16/Modules/ExternalProject.cmake:3236 (_ep_add_download_command)
> cmake/opentelemetry-proto.cmake:9 (ExternalProject_Add)
> CMakeLists.txt:363 (include)
>
>
>
> CMake Error at /build/cpp/opentelemetry_ep-prefix/src/opentelemetry_ep-stamp/opentelemetry_ep-configure-DEBUG.cmake:47 (message):
> Stopping after outputting logs.
> ```
>
> So potentially related to this PR (note, I didn't actually look into it, just looked at commits in the last day that could be related to the new failure, and pinging here in case you could take a look).
It looks like `git` is removed before the build starts: https://github.com/ursacomputing/crossbow/runs/5062761297?check_suite_focus=true#step:6:501.
Should we change that or disable OpenTelemetry for these builds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1029909786
The "python-sdist" nightly build started failing (see https://github.com/ursacomputing/crossbow/runs/5062761297?check_suite_focus=true), with a message that seems related to OpenTelemetry:
```
-- stderr output is:
CMake Error at /usr/share/cmake-3.16/Modules/ExternalProject.cmake:2421 (message):
error: could not find git for clone of opentelemetry-proto
Call Stack (most recent call first):
/usr/share/cmake-3.16/Modules/ExternalProject.cmake:3236 (_ep_add_download_command)
cmake/opentelemetry-proto.cmake:9 (ExternalProject_Add)
CMakeLists.txt:363 (include)
CMake Error at /build/cpp/opentelemetry_ep-prefix/src/opentelemetry_ep-stamp/opentelemetry_ep-configure-DEBUG.cmake:47 (message):
Stopping after outputting logs.
```
So potentially related to this PR (note, I didn't actually look into it, just looked at commits in the last day that could be related to the new failure, and pinging here in case you could take a look).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mbrobbel commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
mbrobbel commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028775427
Disabling OT in Windows builds in this PR. The fix from #11963 should also fix those builds: https://github.com/apache/arrow/blob/8573ba86990968ab95ac8e53d05071f917da93d4/cpp/cmake_modules/ThirdpartyToolchain.cmake#L4126-L4128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028950744
Revision: 105b3c037976ba62460d187dfb6aeb896c6b43e6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1573](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1573)
|Task|Status|
|----|------|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1573-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1573-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-1573-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-1573-azure-test-ubuntu-18.04-r-sanitizer)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005
Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca9d32e0724cd245c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/732dc06332604b5f9b325af50f8dece5...fa793d990b4a42ab87a1ff813475e710/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/904e7917b8954329beeef50209a97232...ab07e005b43d4821a4b228818bfe0146/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c5bbbeb6853842e0921b872d4958ee84...ec29c66cfce149dbb083c695d95b0ad5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005
Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca9d32e0724cd245c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/732dc06332604b5f9b325af50f8dece5...fa793d990b4a42ab87a1ff813475e710/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/904e7917b8954329beeef50209a97232...ab07e005b43d4821a4b228818bfe0146/)
[Finished :arrow_down:0.39% :arrow_up:0.78%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c5bbbeb6853842e0921b872d4958ee84...ec29c66cfce149dbb083c695d95b0ad5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005
Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca9d32e0724cd245c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/732dc06332604b5f9b325af50f8dece5...fa793d990b4a42ab87a1ff813475e710/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/904e7917b8954329beeef50209a97232...ab07e005b43d4821a4b228818bfe0146/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c5bbbeb6853842e0921b872d4958ee84...ec29c66cfce149dbb083c695d95b0ad5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005
Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca9d32e0724cd245c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/732dc06332604b5f9b325af50f8dece5...fa793d990b4a42ab87a1ff813475e710/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/904e7917b8954329beeef50209a97232...ab07e005b43d4821a4b228818bfe0146/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c5bbbeb6853842e0921b872d4958ee84...ec29c66cfce149dbb083c695d95b0ad5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1048519053
> This removal of git was added in #10342, cc @kszucs
@kszucs do you remember the reason for it?
We now have a similar failure of the `python-sdist` build, this time the new substrait option requiring git:
```
CMake Error at /usr/share/cmake-3.16/Modules/ExternalProject.cmake:2421 (message):
error: could not find git for clone of substrait_ep
Call Stack (most recent call first):
/usr/share/cmake-3.16/Modules/ExternalProject.cmake:3236 (_ep_add_download_command)
src/arrow/engine/CMakeLists.txt:50 (externalproject_add)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005
Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca9d32e0724cd245c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/732dc06332604b5f9b325af50f8dece5...fa793d990b4a42ab87a1ff813475e710/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/904e7917b8954329beeef50209a97232...ab07e005b43d4821a4b228818bfe0146/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c5bbbeb6853842e0921b872d4958ee84...ec29c66cfce149dbb083c695d95b0ad5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1031730360
I opened https://github.com/apache/arrow/pull/12356 for the python-sdist failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1048527114
We should pass
```cmake
URL "https://github.com/${ARROW_SUBSTRAIT_REPO}/archive/${ARROW_SUBSTRAIT_TAG}.tar.gz"
```
instead of
https://github.com/apache/arrow/blob/bee67c5f2ff84a1759d02b45d7a0cea9b494175b/cpp/src/arrow/engine/CMakeLists.txt#L51-L52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1029931436
This removal of git was added in https://github.com/apache/arrow/pull/10342, cc @kszucs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12322: ARROW-15533: [C++] ARROW_WITH_OPENTELEMETRY is not checked in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028163746
https://issues.apache.org/jira/browse/ARROW-15533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1048523391
> > This removal of git was added in #10342, cc @kszucs
>
> @kszucs do you remember the reason for it?
Git was used to generate a version number even for a python sdist release with explicit version and already available source code.
> We now have a similar failure of the `python-sdist` build, this time the new substrait option requiring git:
>
> ```
> CMake Error at /usr/share/cmake-3.16/Modules/ExternalProject.cmake:2421 (message):
> error: could not find git for clone of substrait_ep
> Call Stack (most recent call first):
> /usr/share/cmake-3.16/Modules/ExternalProject.cmake:3236 (_ep_add_download_command)
> src/arrow/engine/CMakeLists.txt:50 (externalproject_add)
> ```
I think we should avoid hard dependency on git and prefer downloading tarballs from github.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028893099
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12322:
URL: https://github.com/apache/arrow/pull/12322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028994005
Benchmark runs are scheduled for baseline = 56d060ca197352f575edced64e6a1fbc9331b336 and contender = 7d34a7cad4ed11642641c4eca9d32e0724cd245c. 7d34a7cad4ed11642641c4eca9d32e0724cd245c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/732dc06332604b5f9b325af50f8dece5...fa793d990b4a42ab87a1ff813475e710/)
[Failed :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/904e7917b8954329beeef50209a97232...ab07e005b43d4821a4b228818bfe0146/)
[Finished :arrow_down:0.39% :arrow_up:0.78%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c5bbbeb6853842e0921b872d4958ee84...ec29c66cfce149dbb083c695d95b0ad5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
wjones127 commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028369017
Is the option making it though to the build? I see the env variable but this line suggests it's not actually turned on in the CMake Configure:
https://github.com/apache/arrow/runs/5040342323?check_suite_focus=true#step:7:460
Also, maybe we should also add this to a Linux build, like the `AMD64 Conda C++` one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mbrobbel commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
mbrobbel commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028723684
> Is the option making it though to the build? I see the env variable but this line suggests it's not actually turned on in the CMake Configure:
>
> https://github.com/apache/arrow/runs/5040342323?check_suite_focus=true#step:7:460
>
Thanks for spotting that! I forgot to update the build script.
> Also, maybe we should also add this to a Linux build, like the `AMD64 Conda C++` one?
This is blocked on https://github.com/apache/arrow/pull/11963. I'll add a reminder to that PR to enable OpenTelemetry in CI once that gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1028949986
@github-actions crossbow submit test-ubuntu-18.04-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12322: ARROW-15533: [C++] Check ARROW_WITH_OPENTELEMETRY in CI
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #12322:
URL: https://github.com/apache/arrow/pull/12322#issuecomment-1048525525
> I think we should avoid hard dependency on git and prefer downloading tarballs from github.
Opened a JIRA for this: https://issues.apache.org/jira/browse/ARROW-15760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org