You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/07/19 16:22:41 UTC

[GitHub] [hbase] Apache9 commented on pull request #4634: HBASE-27222 Purge FutureReturnValueIgnored warnings from error prone

Apache9 commented on PR #4634:
URL: https://github.com/apache/hbase/pull/4634#issuecomment-1189298043

   There are still 4 warnings left. For the two metrics one, I do not find a better way to fix, as the scheduleWithFixedRate will return a ScheduledFuture, seems the way is to store it somewhere and cancel it when stop?
   
   And in AssignmentManager, the problem is moveAsync just returns a Future, not a CompletableFuture, so there is no way to register a listener to log the errors if any. We can fix this in the future to let it returns a CompletableFuture, but better in another issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org