You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/11 07:38:34 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #17997: [improve][ci] Avoid PR title check on synchronized
tisonkun opened a new pull request, #17997:
URL: https://github.com/apache/pulsar/pull/17997
cc @nicoloboschi
### Motivation
Reduce unnecessary workflow trigger. See also https://github.com/apache/pulsar/pull/17961#discussion_r991902240.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1275051106
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1274534928
@nicoloboschi Let me think of it. Now I lean toward your suggestion, but we need a better name here to combine these two workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1274519103
As you may noticed, the status of pr title check doesn't show on the report now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1274438848
@nicoloboschi IIRC GitHub Actions schedule workers on [job granularity](https://docs.github.com/en/actions/using-jobs/using-jobs-in-a-workflow). Thus I'd prefer to keep this workflow alone. They're semantically different things and I don't want to do such physical improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17997:
URL: https://github.com/apache/pulsar/pull/17997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1274442088
Also, they're not triggered by same events - this action isn't triggered by labeled/unlabeled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1274557909
Let's continue this patch as it makes something good.
I'll allocate some time for a solution as you suggested and I feel good enough. Some questions:
1. I guess document bot's trigger should be `pull_request` instead of `pull_request_target`.
2. I guess document bot's doesn't need to write `permissions: pull-requests: write` as it's the default.
3. How to continue steps if previous one failed, since they are actually different tasks.
Anyway, I may prefer to spend my time to help with Pulsar CI reduce time and be more stable :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1274922047
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1274423329
@tisonkun another improvement would be to collapse this action into the documentbot workflow. This workflow is triggered on the same events. We could only trigger one runner to do all this doc/writing stuff, WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1274758945
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1275457608
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#discussion_r992123639
##########
.github/workflows/ci-semantic-pull-request.yml:
##########
@@ -24,7 +24,6 @@ on:
- opened
- reopened
- edited
- - synchronize
Review Comment:
```suggestion
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event.number }}
cancel-in-progress: true
```
However, it's possible to squash pending runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #17997: [improve][ci] Avoid PR title check on synchronized
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #17997:
URL: https://github.com/apache/pulsar/pull/17997#issuecomment-1274518215
> @nicoloboschi IIRC GitHub Actions schedule workers on [job granularity](https://docs.github.com/en/actions/using-jobs/using-jobs-in-a-workflow). Thus I'd prefer to keep this workflow alone. They're semantically different things and I don't want to do such physical improvement even if it can improve.
I know they have different semantics and I agree they should be in different files/workflows.
They have different triggers but for each pull created, edited or closed we're going to trigger two different jobs.
My suggestion was about the recycle the same agent and execute this one and the docbot sequentially in one single job with different steps filtered by event type. In this way we're not going to use more than one runner for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org