[jira] [Commented] (YARN-4096) App local logs are leaked if log aggregation fails to initialize for the app

["zhihai xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724577#comment-14724577 ] 

zhihai xu commented on YARN-4096:
---------------------------------

Hi [~jlowe], It is a good catch. It is nice to make an useless variable {{logAggregationDisabled}} become useful. {{initApp}} will catch {{YarnRuntimeException}} and send event {{APPLICATION_LOG_HANDLING_FAILED}} to {{ApplicationImpl}}, {{ApplicationImpl}} will send event {{LogHandlerAppFinishedEvent}} to clean up the local application logs {{doAppLogAggregationPostCleanUp}} when application finished.
+1 for the patch. 

> App local logs are leaked if log aggregation fails to initialize for the app
> ----------------------------------------------------------------------------
>
>                 Key: YARN-4096
>                 URL: https://issues.apache.org/jira/browse/YARN-4096
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: log-aggregation, nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: YARN-4096.001.patch
>
>
> If log aggregation fails to initialize for an application then the local logs will never be deleted.  This is similar to YARN-3476 except this is a failure when log aggregation tries to initialize the app-specific log aggregator rather than a failure during a log upload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)