You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@devlake.apache.org by "JorgeGar (via GitHub)" <gi...@apache.org> on 2023/03/31 06:23:35 UTC
[GitHub] [incubator-devlake-helm-chart] JorgeGar opened a new pull request, #104: feat: enable selection of default Nginx ingress vs generic one.
JorgeGar opened a new pull request, #104:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/104
If `.Values.ingress.useDefaultNginx` is false, then the Nginx-specific parts of the code are removed, and you're left with a generic ingress. This value is true by default.
If `.Values.grafana.useExternal` and `.Values.ingress.useDefaultNginx` are true, then it creates an Nginx redirect ingress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #104: feat: enable selection of default Nginx ingress vs generic one.
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #104:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/104#issuecomment-1493518741
> > /lgtm
> > @matrixji
> > Can this be merged now?
Sure, and currently the chart version is not promoted, we could handle it in the next devlake version updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] JorgeGar commented on pull request #104: feat: enable selection of default Nginx ingress vs generic one.
Posted by "JorgeGar (via GitHub)" <gi...@apache.org>.
JorgeGar commented on PR #104:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/104#issuecomment-1492368244
We integrate it with aws ingress, but in any case it will use the annotations, so as long as the annotations are right, the ingress should work. The idea is to have it as generic as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #104: feat: enable selection of default Nginx ingress vs generic one.
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #104:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/104#issuecomment-1492958149
/lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] abeizn commented on pull request #104: feat: enable selection of default Nginx ingress vs generic one.
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on PR #104:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/104#issuecomment-1491422732
@matrixji Can you help me with a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #104: feat: enable selection of default Nginx ingress vs generic one.
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #104:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/104#issuecomment-1492958376
/lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] abeizn commented on pull request #104: feat: enable selection of default Nginx ingress vs generic one.
Posted by "abeizn (via GitHub)" <gi...@apache.org>.
abeizn commented on PR #104:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/104#issuecomment-1493516894
> /lgtm
@matrixji
Can this be merged now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji merged pull request #104: feat: enable selection of default Nginx ingress vs generic one.
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji merged PR #104:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-helm-chart] matrixji commented on pull request #104: feat: enable selection of default Nginx ingress vs generic one.
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on PR #104:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/104#issuecomment-1491656417
At least the default behaviors are still not changed (when .Values.ingress.useDefaultNginx default is true).
I need some local tests with other ingresses for better understanding. Will be back here soon.
@JorgeGar if you have specific ingress software to integrate with, you could provide the name, and I could do the local test with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org