You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Curt Arnold <ca...@apache.org> on 2007/05/01 16:34:56 UTC
misc/win32/rand.c include order change breaking VC6 build
Rev 421805 (2006/07/14) changed the sequence of imports in misc/win32/
rand.c
http://svn.apache.org/viewvc/apr/apr/trunk/misc/win32/rand.c?
r1=170461&r2=421805
The change was mentioned in http://marc.info/?l=apr-
dev&m=115285245603323&w=2. I'm guessing it is MinGW related since it
mentioned librpcrt4.a.
Xi Wang reported a compile failure related to this change in
2006-09-18: http://marc.info/?l=apr-dev&m=115856814824660&w=2. But
the connection to the recent change did not seem to be made and there
did not seem to be any follow through.
I'm seeing the same compile failure on my pretty vanilla VC6 set up
(no later platform SDK, etc) on Windows 2000.
I'm also seeing compile failures in apr-util/include/apr_ldap.h and
apr-util/misc/apr_thread_pool.c, but I haven't tracked them down.
Re: apr-ldap on VC6 (was Re: misc/win32/rand.c include order change
breaking VC6 build)
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Graham Leggett wrote:
>
> Is there any symbol exported by VC6 that could be used to reliably
> detect if you're really on windows?
The trouble is MS's LDAPv3 is reported as v2. That would be rare, most
clib/sdk's that report v2 are just that.
Re: apr-ldap on VC6 (was Re: misc/win32/rand.c include order change
breaking VC6 build)
Posted by Graham Leggett <mi...@sharp.fm>.
Curt Arnold wrote:
> From a superficial review, it seems the only deficiency in the VC6
> header files is a lack of definitions for LDAP_VENDOR_NAME and
> LDAP_VERSION_MAX. The following will allow apr_util to build with VC6
> with ldap without needing to use a Platform SDK update. Maybe I'm
> missing something however.
This patch assumes that the only platform out there that doesn't export
the two symbols is VC6, and that may not be the case.
Is there any symbol exported by VC6 that could be used to reliably
detect if you're really on windows?
Regards,
Graham
--
apr-ldap on VC6 (was Re: misc/win32/rand.c include order change breaking VC6 build)
Posted by Curt Arnold <ca...@apache.org>.
On May 1, 2007, at 9:48 AM, Davi Arnaut wrote:
> A newer ldap toolkit is required, but you can also disable ldap
> support.
>
From a superficial review, it seems the only deficiency in the VC6
header files is a lack of definitions for LDAP_VENDOR_NAME and
LDAP_VERSION_MAX. The following will allow apr_util to build with
VC6 with ldap without needing to use a Platform SDK update. Maybe
I'm missing something however.
Index: include/apr_ldap.hw
===================================================================
--- include/apr_ldap.hw (revision 534087)
+++ include/apr_ldap.hw (working copy)
@@ -86,7 +86,17 @@
#define LDAPS_PORT 636 /* ldaps:/// default LDAP over TLS port */
#endif
+#if !defined(LDAP_VENDOR_NAME)
+#define LDAP_VENDOR_NAME "Microsoft Corporation."
+#endif
+#if !defined(LDAP_VERSION_MAX)
+#if defined(LDAP_VERSION3)
+#define LDAP_VERSION_MAX 3
+#endif
+#endif
+
+
/* Note: Macros defining const casting has been removed in APR v1.0,
* pending real support for LDAP v2.0 toolkits.
*
Re: misc/win32/rand.c include order change breaking VC6 build
Posted by Davi Arnaut <da...@haxent.com.br>.
On 01/05/2007, at 11:34, Curt Arnold wrote:
> Rev 421805 (2006/07/14) changed the sequence of imports in misc/
> win32/rand.c
>
> http://svn.apache.org/viewvc/apr/apr/trunk/misc/win32/rand.c?
> r1=170461&r2=421805
http://issues.apache.org/bugzilla/show_bug.cgi?id=42293
>
> The change was mentioned in http://marc.info/?l=apr-
> dev&m=115285245603323&w=2. I'm guessing it is MinGW related since
> it mentioned librpcrt4.a.
Needed more information. Blindly changing the headers only hides the
real problem.
>
> Xi Wang reported a compile failure related to this change in
> 2006-09-18: http://marc.info/?l=apr-dev&m=115856814824660&w=2. But
> the connection to the recent change did not seem to be made and
> there did not seem to be any follow through.
>
> I'm seeing the same compile failure on my pretty vanilla VC6 set up
> (no later platform SDK, etc) on Windows 2000.
> I'm also seeing compile failures in apr-util/include/apr_ldap.h and
> apr-util/misc/apr_thread_pool.c, but I haven't tracked them down.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42294
A newer ldap toolkit is required, but you can also disable ldap support.
--
Davi Arnaut