[GitHub] [spark] leesf edited a comment on pull request #35648: [SPARK-38313] Remove deprecated logic in SortMergeJoinExec

[GitBox <gi...@apache.org>]

leesf edited a comment on pull request #35648:
URL: https://github.com/apache/spark/pull/35648#issuecomment-1053787319


   > > However in which case will it exists unmatched rows?
   > 
   > @leesf - Beside the equi join condition, we also have non-equi condition. e.g.
   > 
   > ```
   > SELECT *
   > FROM t1
   > JOIN t2
   > ON 
   >   t1.k = t2.k
   >   AND t1.v != t2.v     <- this is the non-equi condition
   > ```
   > 
   > So rows in left, right buffers have same values for join keys (i.e. `k` column here), but not necessarily pass the non-equi join condition (i.e. `v` column here). `SortMergeJoinExec.condition` is the non-equi condition (i.e. `t1.v != t2.v` here).
   
   Thanks for you explanation and example, you are right and i am going to close the PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org