You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "spetz (via GitHub)" <gi...@apache.org> on 2026/04/21 06:27:04 UTC

[PR] feat(bench): redesign benchmarks dashboard with landing + compare mode [iggy]

spetz opened a new pull request, #3145:
URL: https://github.com/apache/iggy/pull/3145

   The previous dashboard was a flat tabs-and-list layout that buried
   information, had no side-by-side compare, rendered detail charts
   with no landing context, and sometimes picked the worst run as
   "best" (max-by p99 instead of min-by p99).
   
   Reshaped around URL-as-source-of-truth routing (`/`,
   `/benchmarks/:uuid`, `/compare/:a/:b`) with a CSS Grid app-shell:
   unified top bar, dense searchable sidebar (scope toggle, hardware/
   gitref, kind chips, sort, range filters), collapsible benchmark-
   meta chips, and a hero landing with animated tail chart plus stat
   cards. Compare mode pins a second benchmark into side-by-side
   panes with swap/exit.
   
   Along the way: best-run picker now takes lowest p99 within a ±2h
   window with throughput tiebreak and NaN-safe ordering; selection
   retention across hardware/gitref uses UUID to preserve compare
   URLs; a generation counter prevents stale route fetches from
   clobbering newer state; spawn_local tasks cancel on unmount;
   popups auto-close on selection change; sidebar reacts to window
   resize.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(bench): redesign benchmarks dashboard with landing + compare mode [iggy]

Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #3145:
URL: https://github.com/apache/iggy/pull/3145


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(bench): redesign benchmarks dashboard with landing + compare mode [iggy]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3145:
URL: https://github.com/apache/iggy/pull/3145#issuecomment-4286373975

   ## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3145?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 70.72%. Comparing base ([`3630799`](https://app.codecov.io/gh/apache/iggy/commit/36307999b27c3904248d1a414d3706a25404e6cd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`45402f9`](https://app.codecov.io/gh/apache/iggy/commit/45402f9014d1b4e2c9c171bcf22278071ca466c7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3145      +/-   ##
   ============================================
   - Coverage     73.27%   70.72%   -2.55%     
     Complexity      943      943              
   ============================================
     Files          1126     1063      -63     
     Lines         98435    93628    -4807     
     Branches      75609    75522      -87     
   ============================================
   - Hits          72127    66221    -5906     
   - Misses        23702    24898    +1196     
   + Partials       2606     2509      -97     
   ```
   
   | [Components](https://app.codecov.io/gh/apache/iggy/pull/3145/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3145/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.15% <ø> (ø)` | |
   | [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3145/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.30% <ø> (ø)` | |
   | [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3145/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.40% <ø> (ø)` | |
   | [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3145/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.43% <ø> (ø)` | |
   | [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3145/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.29% <ø> (-4.23%)` | :arrow_down: |
   | [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3145/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `11.53% <ø> (-27.89%)` | :arrow_down: |
   [see 122 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3145/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org