[jira] [Commented] (NIFI-2761) BootstrapCodec can throw exceptions with unintended message

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795558#comment-15795558 ] 

ASF GitHub Bot commented on NIFI-2761:
--------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/1385

    NIFI-2761 Fixed error message in bootstrap

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi NIFI-2761

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1385.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1385
    
----
commit fe1adec7eb98eb755480f6aff8fe989ef456e5f0
Author: Pierre Villard <pi...@gmail.com>
Date:   2017-01-03T17:09:53Z

    NIFI-2761 Fixed error message in bootstrap

----


> BootstrapCodec can throw exceptions with unintended message
> -----------------------------------------------------------
>
>                 Key: NIFI-2761
>                 URL: https://issues.apache.org/jira/browse/NIFI-2761
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.0.0
>            Reporter: Jeff Storck
>            Priority: Minor
>
> In BootstrapCodec.java, when the following tertiary expression gets evaluated, it never will be null, due to the string concatination.  This causes the IOException message to always be "Details: " with the InvalidCommandException's toString result.
> {code}
> try {
>     processRequest(cmd, args);
> } catch (final InvalidCommandException ice) {
>     throw new IOException("Received invalid command from NiFi: " + line + " : " + ice.getMessage() == null ? "" : "Details: " + ice.toString());
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)