You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/13 03:29:47 UTC
[GitHub] [druid] adarshsanjeev commented on a diff in pull request #12998: Update ClusterByStatisticsCollectorImpl to use bytes instead of keys
adarshsanjeev commented on code in PR #12998:
URL: https://github.com/apache/druid/pull/12998#discussion_r958444478
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/statistics/DistinctKeyCollector.java:
##########
@@ -43,8 +43,8 @@
*/
public class DistinctKeyCollector implements KeyCollector<DistinctKeyCollector>
{
- static final int INITIAL_MAX_KEYS = 2 << 15 /* 65,536 */;
- static final int SMALLEST_MAX_KEYS = 16;
+ static final int INITIAL_MAX_BYTES = 5_120_000;
+ static final int SMALLEST_MAX_BYTES = 5000;
Review Comment:
I'm not sure if these are the best thresholds here and for PARTITION_STATS_MAX_BYTES. Could someone verify these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org