Re: [PR] [FLINK-37721] Fixes janino bug returning incorrect results [flink]

["AlanConfluent (via GitHub)" <gi...@apache.org>]

AlanConfluent commented on code in PR #26504:
URL: https://github.com/apache/flink/pull/26504#discussion_r2082244238


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/table/AsyncCalcITCase.java:
##########
@@ -238,6 +240,35 @@ public void testFailures() {
         assertThat(results).containsSequence(expectedRows);
     }
 
+    @Test
+    public void testMultiArgumentAsyncWithAdditionalProjection() {
+        // This was the cause of a bug previously where the reference to the sync projection was
+        // getting garbled by janino.

Review Comment:
   Sounds good, added the link



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org