You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/03/29 04:35:02 UTC
Review Request 19820: Adjusted the includes in stout/net.hpp to avoid
definition conflicts caused by netlink.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19820/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Repository: mesos-git
Description
-------
Libnl headers will use linux/if.h, which contains duplicate definitions defined in net/if.h.
To solve that, we just include linux/if.h on linux and net/if.h on Mac.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 7829d0e
Diff: https://reviews.apache.org/r/19820/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 19820: Adjusted the includes in stout/net.hpp to avoid
definition conflicts caused by netlink.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19820/#review39174
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 29, 2014, 3:35 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19820/
> -----------------------------------------------------------
>
> (Updated March 29, 2014, 3:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Libnl headers will use linux/if.h, which contains duplicate definitions defined in net/if.h.
>
> To solve that, we just include linux/if.h on linux and net/if.h on Mac.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 7829d0e
>
> Diff: https://reviews.apache.org/r/19820/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19820: Adjusted the includes in stout/net.hpp to avoid
definition conflicts caused by netlink.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19820/#review39075
-----------------------------------------------------------
Ship it!
Ship It!
- Chi Zhang
On March 29, 2014, 3:35 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19820/
> -----------------------------------------------------------
>
> (Updated March 29, 2014, 3:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Libnl headers will use linux/if.h, which contains duplicate definitions defined in net/if.h.
>
> To solve that, we just include linux/if.h on linux and net/if.h on Mac.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 7829d0e
>
> Diff: https://reviews.apache.org/r/19820/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>