You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "msumit (via GitHub)" <gi...@apache.org> on 2025/08/20 10:11:50 UTC
[PR] [AIP-94] Add support for read-only sql_alchemy sessions [airflow]
msumit opened a new pull request, #54721:
URL: https://github.com/apache/airflow/pull/54721
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Added support for specifying and connecting to read-only database connections. This feature would be very useful for orgs that are running Airflow at a huge scale and would need to safeguard their database's master node from a very high QPS.
**Key Features**
Automatic Fallback
If read-only database is not configured or unavailable, operations seamlessly fall back to the master database.
Session Type Safety
The implementation maintains type safety with NEW_READONLY_SESSION constant that follows the same pattern as NEW_SESSION.
**Performance Benefits**
Offloads read-heavy operations from master database
Enables horizontal scaling of read capacity
Reduces contention on master database
**Easy Adoption**
Drop-in replacement: Change @provide_session to @provide_readonly_session
Context managers available for manual session management
Backward compatible - existing code continues to work
PS: This diff is not in the final phase yet and needs to add unit tests and documentation.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 🚧 [AIP-94] Add support for read-only sql_alchemy sessions [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #54721:
URL: https://github.com/apache/airflow/pull/54721#discussion_r2288081575
##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -472,9 +472,9 @@ def latest_item_select_object(cls, dag_id):
return select(cls).where(cls.dag_id == dag_id).order_by(cls.created_at.desc()).limit(1)
@classmethod
- @provide_session
+ @provide_readonly_session
def get_latest_serialized_dags(
- cls, *, dag_ids: list[str], session: Session = NEW_SESSION
+ cls, *, dag_ids: list[str], session: Session = NEW_READONLY_SESSION
Review Comment:
(I know this is draft and to go with the AIP, so I haven't looked much beyond this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 🚧 [AIP-94] Add support for read-only sql_alchemy sessions [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #54721:
URL: https://github.com/apache/airflow/pull/54721#issuecomment-3368624180
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 🚧 [AIP-94] Add support for read-only sql_alchemy sessions [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #54721: 🚧 [AIP-94] Add support for read-only sql_alchemy sessions
URL: https://github.com/apache/airflow/pull/54721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] 🚧 [AIP-94] Add support for read-only sql_alchemy sessions [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #54721:
URL: https://github.com/apache/airflow/pull/54721#discussion_r2288074053
##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -472,9 +472,9 @@ def latest_item_select_object(cls, dag_id):
return select(cls).where(cls.dag_id == dag_id).order_by(cls.created_at.desc()).limit(1)
@classmethod
- @provide_session
+ @provide_readonly_session
def get_latest_serialized_dags(
- cls, *, dag_ids: list[str], session: Session = NEW_SESSION
+ cls, *, dag_ids: list[str], session: Session = NEW_READONLY_SESSION
Review Comment:
Nit: I don't think we need `NEW_READONLY_SESSION` to be distinct from `NEW_SESSION` -- as the default doesn't actually do anything
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org