You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/04/20 18:09:00 UTC

[GitHub] [hive] omalley commented on issue #983: HIVE-23215. Make FilterContext an interface.

omalley commented on issue #983:
URL: https://github.com/apache/hive/pull/983#issuecomment-616722525


   This seems to work well when I was working with the filters for ORC-577. A couple of comments:
   * It feels a little worrisome letting the user pass in a selection array and they never know the right length without calling getSelectionSize first.
   * We probably don't need the separate setSelectedInUser and setSelectedSize. All of the filters would just call setFilterContext to set both in a single call.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org