[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #186: Store offset ranges for parquet files

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #186: Store offset ranges for parquet files
URL: https://github.com/apache/incubator-iceberg/pull/186#discussion_r284459133
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/DataFile.java
 ##########
 @@ -137,4 +138,9 @@ static StructType getType(StructType partitionType) {
    * @return a copy of this data file
    */
   DataFile copy();
+
+  /**
+   * @return a list of offsets for file blocks if applicable, null otherwise
+   */
+  List<Long> offsetRanges();
 
 Review comment:
   Why is this named "offsetRanges" instead of "offsets"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org