You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "porcelli (via GitHub)" <gi...@apache.org> on 2024/01/23 22:56:45 UTC
[PR] #817 - removing oracle database dependency [incubator-kie-kogito-apps]
porcelli opened a new pull request, #1968:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/1968
This PR is related to https://github.com/apache/incubator-kie-issues/issues/817
Related PR:
- https://github.com/apache/incubator-kie-kogito-runtimes/pull/3369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] #817 - removing oracle database dependency [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado closed pull request #1968: #817 - removing oracle database dependency
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/1968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] #817 - removing oracle database dependency [incubator-kie-kogito-apps]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on PR #1968:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/1968#issuecomment-1907890509
note: community may ask for support and we might not be able to cover the request for legal reasons....
my perspective is to not have unused code left behind just because... that's the value of version control (we can always revert if different interpretation of category X is provided)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] #817 - removing oracle database dependency [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on PR #1968:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/1968#issuecomment-1907849343
@porcelli I see that rather than removing the Oracle driver, we are completely removing Oracle db support.
To be honest, I would have been more conservative, because there is not actually source code depending on oracle stuff to support oracle (since we are using JPA).
So, It would have been posible to leave references to Oracle and just remove the driver from the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] #817 - removing oracle database dependency [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on PR #1968:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/1968#issuecomment-1964409803
Already implemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] #817 - removing oracle database dependency [incubator-kie-kogito-apps]
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on PR #1968:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/1968#issuecomment-1907861985
@fjtirado i just wrote this to ML:
I might be interpreting the Category X dependency way too strictly; but it’s my current understanding that we cannot have such dependency in our codebase at all.
The direction that we agreed is to avoid endless discussion and just remove for now; once we past the critical phase of our first release- we can try to explore and discuss different angles to tackle the Category X dependency; it’s just not worth spend time right now on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] #817 - removing oracle database dependency [incubator-kie-kogito-apps]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on PR #1968:
URL: https://github.com/apache/incubator-kie-kogito-apps/pull/1968#issuecomment-1907868085
@porcelli
We spent quite amount of time on avoiding code duplication for Oracle and Postgresql and we will have to spent again when in future community ask for oracle support (as they already did in the past, the oracle support, a lot of copy paste from postgres that was later refactor, was added by community folks on their spare time) . I do not really see the problem on just removing the driver and test and keep the source code that does not depend on the driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org